Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333652

Summary: Extension point offering the possibility to declare an EPackage browser
Product: z_Archived Reporter: Gregoire Dupe <gdupe>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: emft.facet-inbox, nicolas.guyomar
Version: unspecifiedFlags: gdupe: indigo+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 333651    
Attachments:
Description Flags
org.eclipse.emf.facet.common.core
gdupe: iplog+
org.eclipse.emf.facet.common.ui
gdupe: iplog+
org.eclipse.emf.facet.util.emf.ui
gdupe: iplog+
Bug 333652
gdupe: iplog+
org.eclipse.emf.facet.common.feature gdupe: iplog+

Description Gregoire Dupe CLA 2011-01-06 08:47:01 EST
Hello,

An extension point offering the possibility to declare an EPackage browser is
needed to be able to use the MoDisco browser to display the meta-models.

The EPackage view and the metamodel browsing button have to use this extension point.

Regards,
Gregoire Dupe
Comment 1 Nicolas Guyomar CLA 2011-01-07 11:29:52 EST
Created attachment 186284 [details]
org.eclipse.emf.facet.common.core

Hi, 
As part of the refactoring MoDisco/ EMF Facet, please find attached the new plugin org.eclipse.emf.facet.common.core 

Regards

Nicolas Guyomar
Comment 2 Nicolas Guyomar CLA 2011-01-07 11:30:14 EST
Created attachment 186285 [details]
org.eclipse.emf.facet.common.ui

Hi, 
As part of the refactoring MoDisco/ EMF Facet, please find attached the new plugin org.eclipse.emf.facet.common.ui

Regards

Nicolas Guyomar
Comment 3 Nicolas Guyomar CLA 2011-01-07 11:36:47 EST
Created attachment 186286 [details]
org.eclipse.emf.facet.util.emf.ui

Hi,

Please find attached a new plugin with its test plugin to meet this bug requirements : 

Creation of an extension point to provide the "EPackage Registry View"/"EPackage Registry Dialog" with a model browser.

This browser has to be registered with the extension point and can be set using the preference page "EMF Facet" > "EPackage Browser" .

Regards

Nicolas Guyomar
Comment 4 Nicolas Guyomar CLA 2011-01-07 11:39:53 EST
Comment on attachment 186284 [details]
org.eclipse.emf.facet.common.core

The authors of the plugin org.eclipse.emf.facet.common.core are : 
Nicolas Bros (Commiter)
Nicolas Guyomar
Comment 5 Nicolas Guyomar CLA 2011-01-07 11:40:52 EST
Comment on attachment 186285 [details]
org.eclipse.emf.facet.common.ui

The authors of the plugin org.eclipse.emf.facet.common.ui are : 
Nicolas Bros (Commiter)
Nicolas Guyomar
Comment 6 Nicolas Guyomar CLA 2011-01-07 11:42:27 EST
Comment on attachment 186286 [details]
org.eclipse.emf.facet.util.emf.ui

The authors of the plugin org.eclipse.emf.facet.util.emf.ui are : 
Gabriel Barbier (Commiter)
Gregoire Dupe (Commiter)
Nicolas Bros (Commiter)
Nicolas Guyomar
Comment 7 Nicolas Guyomar CLA 2011-01-07 11:50:27 EST
Created attachment 186289 [details]
Bug 333652

Hi,

Please find attached a patch on projects : 
- org.eclipse.emf.facet.infra.browser
- org.eclipse.emf.facet.infra.browser.custom.ui
- org.eclipse.emf.facet.infra.common.core
- org.eclipse.emf.facet.infra.common.ui
- org.eclipse.emf.facet.infra.facet.editor
- org.eclipse.emf.facet.infra.facet.ui
- org.eclipse.emf.facet.infra.query.editor
- org.eclipse.emf.facet.infra.query.ui

which deals with the side effects of the previous attachment (code refactoring)

(a) I, Nicolas Guyomar, wrote 100% of the code of this patch.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards

Nicolas Guyomar
Comment 8 Nicolas Guyomar CLA 2011-01-07 11:54:25 EST
Hi,

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided in the plug-ins : 
 - org.eclipse.emf.facet.common.core
 - org.eclipse.emf.facet.common.ui
 - org.eclipse.emf.facet.util.emf.ui
 - org.eclipse.emf.facet.util.emf.ui.tests (contained in org.eclipse.emf.facet.util.emf.ui.zip)

(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar
Comment 9 Gregoire Dupe CLA 2011-01-10 10:23:45 EST
Hello,

I’ve commited the following plug-ins:
 - org.eclipse.emf.facet.common.core (committed revision: 174 and 175) 
    * I’ve added a .checkstyle file
    * I’ve externalized strings
 - org.eclipse.emf.facet.common.ui (committed revision: 177)
    * I’ve externalized strings
 - org.eclipse.emf.facet.util.emf (committed revision: 179)
 - org.eclipse.emf.facet.util.emf.ui.tests (committed revision 181)
    * I’ve added a .checkstyle file.
    * I’ve externalized strings.

I've applies of the Nicolas Gyuomar's patch (committed revision 182).

The old epackge browser UI elements have been refactored and moved:
 - EmfFacetRootPreferencePage  has been moved to org.eclipse.emf.facet.common.ui.internal.preference.pages
 - AnywhereFilterMatcher has been moved to org.eclipse.emf.facet.common.ui.internal.widgets
 - StringMatcher has been moved to org.eclipse.emf.facet.common.core.internal.utils
 - AbstractCatalogView has been refactored and moved to AbstractTreeView.
 - PackageRegistryView has been moved to org.eclipse.emf.facet.util.emf.ui.internal.view.

Regards,
Grégoire
Comment 10 Gregoire Dupe CLA 2011-01-10 10:26:54 EST
Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).
Comment 11 Gregoire Dupe CLA 2011-01-10 10:30:05 EST
Created attachment 186396 [details]
org.eclipse.emf.facet.common.feature

Here is a new feature needed to add the new plug-ins in the releng.
Comment 12 Gregoire Dupe CLA 2011-01-10 10:32:39 EST
I've commited the feature org.eclipse.emf.facet.common.

Committed revision 184.
Comment 13 Gregoire Dupe CLA 2011-01-10 11:03:53 EST
I’ve added the a dependency to the feature org.eclipse.emf.facet.common in the feature org.eclipse.emf.facet.sdk.

Committed revision 185.
Comment 14 Gregoire Dupe CLA 2011-01-11 09:25:31 EST
It works with EMF Facet 0.1.0.v201101101615 and MoDisco 0.9.0.v201101111211.

Regards,
Gregoire Dupe