Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333606

Summary: [TMF] Refresh problems in TMF events table
Product: z_Archived Reporter: Bernd Hufmann <bernd.hufmann>
Component: LinuxToolsAssignee: Bernd Hufmann <bernd.hufmann>
Status: CLOSED FIXED QA Contact: Francois Chouinard <fchouinard>
Severity: normal    
Priority: P3 CC: jjohnstn
Version: unspecifiedFlags: fchouinard: review+
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Fix for refresh problems
bernd.hufmann: iplog-
Fix for refresh problems
bernd.hufmann: iplog-
Fix for refresh problems
bernd.hufmann: iplog-
Fix for refresh problems jjohnstn: iplog+

Description Bernd Hufmann CLA 2011-01-05 15:51:47 EST 
There are two refresh problems reported in this bug report:

1) When the TmfEventsTable processes the signal TmfTimeSynchSignal to synchronize to a specific event time and the event time is at the end (...), then it fetches events from the trace repeatedly. It only stops if the uses jumps to a different event that is not at the end. This repeated fetching can be seen through the progress monitor of the job to fetch the events or in the progress view.

2) The selection in the TmfEventsTable is not updated when performing the following steps:
   a) Press end-button to go the last event
   b) Select second last event with mouse
   c) Press end-button to go the last event again. The selection is not done.

Any trace is suitable to reproduce the above problems.
Comment 1 Bernd Hufmann CLA 2011-01-05 16:24:33 EST 
Created attachment 186129 [details]
Fix for refresh problems

The attached patch fixes both reported refresh problems.

1) When selecting a row (event) in the event table during processing of the signal TmfTimeSynchSignal, the old implementation sets the selected row in the middle of the visible table. E.g if 5 rows are visible the selected event is row 3. This causes a problem if the selected event is at the end of the table and not enough events are available in the trace after the to be selected event to set it in the middle of the table. The attached fix checks if enough events are available, before setting the selected row and the top row to be displayed. If not enough events are available it sets the selected row and the top displayed row accordingly.

2) If the to be selected event is in the event cache when executing step c) of the bug report, then the table is not redrawn. The attached fix makes sure that a notification to the relevant items is sent in this case.
Comment 2 Bernd Hufmann CLA 2011-01-07 09:33:55 EST 
Created attachment 186273 [details]
Fix for refresh problems

This patch augments patch submitted in attachment 186129 [details]. On top of patch 186129, it fixes another refresh problem and it includes a time range verification when selecting a specif event time.
Comment 3 Bernd Hufmann CLA 2011-01-07 10:05:35 EST 
Created attachment 186279 [details]
Fix for refresh problems

This patch replaces previously submitted attachment 186273 [details], because attachment 186273 [details] was the wrong file. Sorry about that. 

This patch contains all the relevant fixes for this bug.
Comment 4 Bernd Hufmann CLA 2011-01-07 16:27:35 EST 
Created attachment 186316 [details]
Fix for refresh problems

This patch contains all previously submitted changes and improves the inter-component synchronization. I.e. it avoids that the Event Table re-synchronizes the timestamp if the timestamp of the initial signal from a source component (CFV) is not in the trace.
Comment 5 Bernd Hufmann CLA 2011-01-10 10:24:59 EST 
Hi Francois
Could you please review the latest patch before I commit it?
Thank you!
Comment 6 Francois Chouinard CLA 2011-01-11 18:08:02 EST 
Looks great!
Comment 7 Bernd Hufmann CLA 2011-01-12 16:23:52 EST 
Comment on attachment 186316 [details]
Fix for refresh problems

Patch committed
Comment 8 Bernd Hufmann CLA 2011-01-12 16:25:44 EST 
Bug fixed with committed patch (attachment 186316 [details])
Comment 9 Francois Chouinard CLA 2011-07-22 14:58:44 EDT 
Delivered with 0.8