Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333553

Summary: The user has not to deal with two files to create a facet
Product: z_Archived Reporter: Gregoire Dupe <gdupe>
Component: EMF-FacetAssignee: Gregoire Dupe <gdupe>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P2 CC: emft.facet-inbox, nicolas.bros, nicolas.guyomar
Version: unspecifiedFlags: gdupe: indigo+
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 334000, 334286, 334529    
Bug Blocks: 352718    
Attachments:
Description Flags
Bug 333553
none
org.eclipse.emf.facet.efacet
none
org.eclipse.emf.facet.efacet
gdupe: iplog+
org.eclipse.emf.facet.efacet.catalog
none
org.eclipse.emf.facet.efacet.catalog.tests
none
org.eclipse.emf.facet.efacet.core
gdupe: iplog+
org.eclipse.emf.facet.efacet.catalog
none
org.eclipse.emf.facet.efacet.catalog.tests
gdupe: iplog+
org.eclipse.emf.facet.efacet.catalog
gdupe: iplog+
org.eclipse.emf.facet.efacet: Patch to add QueryContext
gdupe: iplog+
Query/Facet Framework implementation
none
org.eclipse.emf.facet.efacet.catalog : Derived attributes implementation
gdupe: iplog+
org.eclipse.emf.facet.efacet.core : Query Framework Implementation
none
org.eclipse.emf.facet.efacet.core : Query Framework Implementation gdupe: iplog+

Description Gregoire Dupe CLA 2011-01-05 05:27:39 EST
Hello,

It's too boring for the user to deal with two files to create a facet. We have to merge the query and facet metamodel.

Regards,
Gregoire Dupe
Comment 1 Nicolas Guyomar CLA 2011-01-05 06:17:06 EST
Created attachment 186083 [details]
Bug 333553

Hi,

Please find attached a merged version for facet and query metamodel.

Authors are Gregoire Dupe (commiter) and myself

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar
Comment 2 Nicolas Guyomar CLA 2011-01-05 10:13:39 EST
Created attachment 186088 [details]
org.eclipse.emf.facet.efacet

Fix for metamodel naming modification
Comment 3 Nicolas Guyomar CLA 2011-01-11 09:35:09 EST
Created attachment 186502 [details]
org.eclipse.emf.facet.efacet

Hi,

The Metamodel documentation has been updated.

Nicolas Guyomar
Comment 4 Gregoire Dupe CLA 2011-01-11 09:49:34 EST
Comment on attachment 186502 [details]
org.eclipse.emf.facet.efacet

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).
Comment 5 Gregoire Dupe CLA 2011-01-11 09:53:31 EST
Comment on attachment 186502 [details]
org.eclipse.emf.facet.efacet

I've committed this contribution.

Committed revision 187.
Comment 6 Nicolas Guyomar CLA 2011-01-12 03:53:39 EST
Created attachment 186600 [details]
org.eclipse.emf.facet.efacet.catalog

Hi,

Here is a contribution which uses the "EMF Facet Catalog Manager".

It contains the efacetcatalog model for Facet and Query management.

The authors of this plugin are : 
Gregoire dupe (commiter)
Nicolas Guyomar
Comment 7 Nicolas Guyomar CLA 2011-01-12 03:55:33 EST
Created attachment 186602 [details]
org.eclipse.emf.facet.efacet.catalog.tests

Hi,

Here is the tests plug-in associated with org.eclipse.emf.facet.efacet.catalog

I am the author of this plug-in
Comment 8 Nicolas Guyomar CLA 2011-01-12 03:57:36 EST
Created attachment 186603 [details]
org.eclipse.emf.facet.efacet.core

Hi,

Here is a contribution containing the implementation of the EMF EFacetCatalogManager.

The authors of this plug-in are:
 - Gregoire Dupe (commiter)
 - Nicolas Guyomar
Comment 9 Nicolas Guyomar CLA 2011-01-12 03:58:44 EST
Hi,

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided in the plug-ins:

 - org.eclipse.emf.facet.efacet.catalog
 - org.eclipse.emf.facet.efacet.catalog.tests
 - org.eclipse.emf.facet.efacet.core

(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar
Comment 10 Nicolas Guyomar CLA 2011-01-12 05:30:27 EST
Created attachment 186608 [details]
org.eclipse.emf.facet.efacet.catalog

Hi,

I have added some documentation to this plug-in

Regards

Nicolas Guyomar
Comment 11 Nicolas Guyomar CLA 2011-01-12 05:33:50 EST
Created attachment 186609 [details]
org.eclipse.emf.facet.efacet.catalog.tests

Hi,

Tests have been updated.

Regards

Nicolas Guyomar
Comment 12 Nicolas Guyomar CLA 2011-01-12 09:40:36 EST
Created attachment 186638 [details]
org.eclipse.emf.facet.efacet.catalog

Hi,

I have renamed a package since the plug-in name was changed.

Package org.eclipse.emf.facet.efacet.core is now know as org.eclipse.emf.facet.efacet.catalog

Nicolas Guyomar
Comment 13 Gregoire Dupe CLA 2011-01-13 09:28:28 EST
Comment on attachment 186638 [details]
org.eclipse.emf.facet.efacet.catalog

Hello,

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've commited this plugin. (Committed revision 196.)

Regards,
Gregoire Dupe
Comment 14 Gregoire Dupe CLA 2011-01-13 09:52:59 EST
Comment on attachment 186603 [details]
org.eclipse.emf.facet.efacet.core

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed the plug-in. (Committed revision 199.)
Comment 15 Gregoire Dupe CLA 2011-01-13 10:08:40 EST
Comment on attachment 186609 [details]
org.eclipse.emf.facet.efacet.catalog.tests

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this test plug-in. (Committed revision 203.)
Comment 16 Gregoire Dupe CLA 2011-01-13 10:13:01 EST
I've added the plug-ins "org.eclipse.emf.facet.efacet.catalog" and "org.eclipse.emf.facet.efacet.core" in the feature "org.eclipse.emf.facet.common.feature".
Comment 17 Nicolas Guyomar CLA 2011-01-18 03:50:08 EST
Created attachment 186979 [details]
org.eclipse.emf.facet.efacet: Patch to add QueryContext

Hi,

I've modified efacet.ecore model in order to add QueryContext.

This is a class used to evaluate a query on every given model element.

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar
Comment 18 Nicolas Guyomar CLA 2011-01-18 05:27:21 EST
Created attachment 186987 [details]
Query/Facet Framework implementation

Hi,

Please find attached a first contribution for the EMF query/facet framework implementation.

An utilization example will be provided in bug 334615 for java queries.

Users can now register Evaluator to evaluate their queries.

Authors are Gregoire Dupe (commiter) and myself
(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.


Regards

Nicolas Guyomar
Comment 19 Gregoire Dupe CLA 2011-01-18 08:51:37 EST
Comment on attachment 186979 [details]
org.eclipse.emf.facet.efacet: Patch to add QueryContext

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this test plug-in. (Committed revision 213.)
Comment 20 Nicolas Guyomar CLA 2011-01-18 09:48:49 EST
Created attachment 187003 [details]
org.eclipse.emf.facet.efacet.catalog : Derived attributes implementation

Hi,

installedQuerySets and installedFacetSets attributes in efacet.ecore needed to be implemented.

This implementation is contained in the attached patch 

(a) I, Nicolas Guyomar, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.

Regards
Nicolas Guyomar
Comment 21 Nicolas Guyomar CLA 2011-01-18 10:08:09 EST
Created attachment 187006 [details]
org.eclipse.emf.facet.efacet.core : Query Framework Implementation

Updated Implementation

Nicolas Guyomar
Comment 22 Gregoire Dupe CLA 2011-01-18 10:14:30 EST
Comment on attachment 187003 [details]
org.eclipse.emf.facet.efacet.catalog : Derived attributes implementation

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've committed this patch. (Committed revision 217.)
Comment 23 Nicolas Guyomar CLA 2011-01-19 03:47:49 EST
Created attachment 187081 [details]
org.eclipse.emf.facet.efacet.core : Query Framework Implementation

Updated Query Implementation

Nicolas Guyomar
Comment 24 Gregoire Dupe CLA 2011-01-19 04:36:06 EST
Comment on attachment 187081 [details]
org.eclipse.emf.facet.efacet.core : Query Framework Implementation

Hi,

Here are contributions from an employee of Mia-Software, targeting future
Indigo release. The company has signed a Member Commiter Agreement. The
contribution does not need a CQ (see bug 322327).

I've commited this patch. (Committed revision 218.)

Regards,
Gregoire Dupe
Comment 25 Nicolas Bros CLA 2011-09-23 07:54:33 EDT
All the patches have been committed. I'm marking the bug as fixed.
Comment 26 Gregoire Dupe CLA 2012-05-23 07:08:53 EDT
This bug can be closed.