Bugzilla – Full Text Bug Listing
| Summary: | Rendering engine only shows one part for a window with two parts | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Remy Suen <remy.suen> | ||||||||
| Component: | UI | Assignee: | Eric Moffatt <emoffatt> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | major | ||||||||||
| Priority: | P3 | CC: | pwebster | ||||||||
| Version: | 4.1 | ||||||||||
| Target Milestone: | 4.2 M1 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
This was almost certainly introduced during the implementation for Bug 317849. Here we replaced the shell's client area's existing layout (FillLayout) with a SashLayout, meaning that multiple children not in a sash container will no longer get 'tiled'. The current implementation is suspect in that it ties the various renderers (Perspective, Window, Area) to a particular Sash rendering mechanism and should likely be replaced by one that creates a specific Composite for the top level sash container (with a SashLayout) and then reverting the changes to the layout of the other renderers (i.e. they'd go back to FillLayout, fixing this defect). Created attachment 186170 [details]
Make the SashLayout handling local to the SashRenderer
This implements the suggestions outlined in the comment above...
Committed in >20110106. Applied the patch. (In reply to comment #2) > Created attachment 186170 [details] > Make the SashLayout handling local to the SashRenderer PartRenderingEngineTests's testBug317849() now dies with an NPE. Created attachment 199906 [details]
Handle shared PSC's
The renderer wasn't handling the scenario where it was a shared element (i.e. 'getParent() == null').
Also updated the test to add the shared PSC to its window's 'sharedParts' list...
*** Bug 333869 has been marked as a duplicate of this bug. *** Committed in >20110619. Applied the patch. |
Created attachment 186023 [details] Test Application.e4xmi Please override your local contacts demo's Application.e4xmi file with the one attached to this bug. When you launch you will see only one part despite the fact that the parent window has _two_ children. The workaround is to wrap the two children in an MPartSashContainer.