Bugzilla – Full Text Bug Listing
| Summary: | NullPointerException when opening the Test Log editor without BIRT/DTP/GMF. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Paul Slauenwhite <paulslau> | ||||
| Component: | TPTP | Assignee: | Joel Cayne <jcayne> | ||||
| Status: | CLOSED FIXED | QA Contact: | Kathy Chan <kathy> | ||||
| Severity: | critical | ||||||
| Priority: | P1 | CC: | jerome.bozier | ||||
| Version: | unspecified | Flags: | paulslau:
review+
jerome.bozier: review+ |
||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Paul Slauenwhite
Requires a new test case. Regression from TPTP The problem is that isBIRTAvailable is being set to true in org.eclipse.hyades.test.ui.forms.editor.page.LogOverviewPage.createFormContent(IManagedForm) causing org.eclipse.hyades.test.ui.forms.base.VerdictSummaryChart.VerdictSummaryChart(Composite, int) to be called from org.eclipse.hyades.test.ui.forms.editor.page.LogOverviewPage.createOverviewPart(IManagedForm, Composite) when the VerdictSummaryChart should not be created. It appears that installing the TPTP 4.7.1 Test Framework and Tools using the Eclipse 3.6.1 Update Manager does install BIRT/DTP/GMF (Joel, can you confirm if this correct?) but the bundle could not be started (possibly missing dependencies, etc.). Either way, we need to handle this condition in the code as well as confirm why the install using the Update Manager is pulling in BIRT/DTP/GMF. Solution (org.eclipse.hyades.test.ui.forms.editor.page.LogOverviewPage.createFormContent(IManagedForm)):
if(birtChartBundle != null){
//Attempt to start the bundle:
birtChartBundle.start();
//Check if the bundling is started and activated (e.g. running):
isBIRTAvailable = (birtChartBundle.getState() == Bundle.ACTIVE);
}
(In reply to comment #5) > Solution > (org.eclipse.hyades.test.ui.forms.editor.page.LogOverviewPage.createFormContent(IManagedForm)): > > if(birtChartBundle != null){ > > //Attempt to start the bundle: > birtChartBundle.start(); > > //Check if the bundling is started and activated (e.g. running): > isBIRTAvailable = (birtChartBundle.getState() == Bundle.ACTIVE); > } Jerome, please test this fix with org.eclipse.birt.chart.engine starting and/or started to ensure the isBIRTAvailable is still set to true. updating worked time test done : . config 1 : eclipse + tptp + birt . config 2 : eclipse + tptp + NO birt (install with zip files) . config 3 : eclipse + tptp + NO birt (install with eclipse install menu) config 1 & 2 works fine (in 2, we detect that birt is not there, so we avoid to use it) in config 3, birt is there but is not functional : it seems that some part are missing we are able to start birt plugin an at this moment, all runs fine, so we memorize that we will use it but when we try to use it, test log produce exception because birt itself see that it miss something to do his job assigning bug to Joel as on code side, we are unable to detect when birt is partially installed Created attachment 186320 [details] Patch to update manifest require bundles I added breakpoints to VerdictSummary and Generator. TPTP located the BIRT bundle but was missing some BIRT dependencies. Based on http://dev.eclipse.org/newslists/news.eclipse.birt/msg11418.html, I added a dependency on org.eclipse.birt.chart.device.swt. A Null Pointer Exception still occurred: java.lang.NullPointerException at org.eclipse.birt.chart.factory.Generator.render(Generator.java:1233) at org.eclipse.hyades.test.ui.forms.base.VerdictSummaryChart.paintControl(VerdictSummaryChart.java:291) Based on http://www.eclipse.org/forums/index.php?t=msg&th=66620&S=54f26b4831b79bf8adbb38938a81caf7, I added a dependency on org.eclipse.birt.chart.engine.extension. Tested using a local p2 repository installation. Paul, Can you please review? Thanks! Thanks Joel. Patched reviewed with comments: -Please test the fix with manual installation (download/unzip) by refactoring the org.eclipse.hyades.test.ui manifest before the installation with and without BIRT/DTP/GMF. -Please test the P2 installation scenario with BIRT/DTP/GMF. Tested with an exported plug-in containing the changes in the patch for the following scenarios: - Eclipse SDK with EMF, XSD and TPTP SDK installed in the dropins folder. No errors in the error log. Graph and verdict list not shown. - Eclipse SDK with EMF, XSD, BIRT, DTP, GEF and TPTP SDK installed in the dropins folder. No errors in the error log. Graph and verdict list displayed. - Eclipse SDK with EMF, XSD, BIRT, DTP and GEF installed in the dropins folder. TPTP Runtime (Platform, Test, and Trace projects) installed using a local p2 update site with contact all update sites unchecked. No errors in the error log. Graph and verdict list displayed. Tested using TPTP-4.7.2-201101101900 and its dependencies. Excellent results. Thanks Joel! Jerome, Can you please provide Test project approval for check-in to HEAD? Thanks! patch approved very good job Joel delivering it under CVS Joel, when will the Eclipse update site be updated to verify this fix? Verified using TPTP-4.7.2-201101211900 using the all-in-one Zip. Requires verification of the update scenario. The Helios RC1 staging repository is available for testing. (In reply to comment #17) > The Helios RC1 staging repository is available for testing. Helios RC1 staging repository: http://download.eclipse.org/releases/maintenance/ (see http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg05272.html - thanks to Joel). Verified using the Helios RC1 staging repository. Closing. |