Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333453

Summary: checkbox cleared when changing tab in remote application debug configuration
Product: [Tools] CDT Reporter: stijn.souffriau
Component: cdt-debugAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: minor    
Priority: P3 CC: anna.dushistova, cdtdoug, marc.khouzam, pawel.1.piech
Version: 7.0.1   
Target Milestone: 7.0.2   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch that fixes the problem
none
Alternative fix
marc.khouzam: iplog-
patch for the CDI main tab
none
correct patch
marc.khouzam: iplog+, marc.khouzam: review+
Solution for HEAD
marc.khouzam: iplog-
Solution for the 7_0 branch marc.khouzam: iplog-

Description stijn.souffriau CLA 2011-01-04 04:45:27 EST 
Build Identifier: M20100211-1343

The (Label)"Skip download to target path" checkbox is cleared every time you change from the (Title)"Main" tab to another one. This happens in the Debug configurations dialog for "C/C++ Remote Applications".


Reproducible: Always

Steps to Reproduce:
1. Make a C/C++ remote application debug configuration
2. Check the "Skip download to target path" box in the Main tab
3. Change to another tab
4. Go back to the Main tab. (the box should be cleared)
Comment 1 Anna Dushistova CLA 2011-01-04 05:05:11 EST 
Remote launcher plugin was moved to CDT several years ago.
Comment 2 Anna Dushistova CLA 2011-01-04 15:34:37 EST 
Created attachment 186046 [details]
patch that fixes the problem
Comment 3 Marc Khouzam CLA 2011-01-12 15:32:56 EST 
Created attachment 186672 [details]
Alternative fix

(In reply to comment #2)
> Created attachment 186046 [details]
> patch that fixes the problem

Hi Anna,

Looking at the other tabs that use updateLaunchConfigurationDialog() in the rest of CDT, I don't them disabling that method during initialization, so I'm not sure this is the way to go.

How about this simpler solution instead.  It seems to work with my tests.

I've only done it for DSF-GDB, so if you think the solution is good, you can port it to CDI.
Comment 4 Anna Dushistova CLA 2011-01-12 15:44:10 EST 
Marc, thanks a lot, I overlooked this one. I'll port it to CDI and post the patch.
Comment 5 Anna Dushistova CLA 2011-01-12 16:53:28 EST 
Created attachment 186683 [details]
patch for the CDI main tab

Marc, here is the patch for the RemoteCMainTab.
Comment 6 Marc Khouzam CLA 2011-01-13 09:47:19 EST 
(In reply to comment #5)
> Created attachment 186683 [details]
> patch for the CDI main tab
> 
> Marc, here is the patch for the RemoteCMainTab.

Looks like the same patch as before...
Comment 7 Anna Dushistova CLA 2011-01-13 10:25:55 EST 
Created attachment 186732 [details]
correct patch

My bad, here is the correct one.
Comment 9 Marc Khouzam CLA 2011-01-14 12:56:08 EST 
Created attachment 186835 [details]
Solution for HEAD

This is what I applied to HEAD
Comment 10 Marc Khouzam CLA 2011-01-14 12:59:44 EST 
Created attachment 186836 [details]
Solution for the 7_0 branch

And this is the patch for the 7_0 branch which I committed.
Comment 11 Marc Khouzam CLA 2011-01-14 12:59:58 EST 
Fixed.

Thanks Anna.
Comment 12 CDT Genie CLA 2011-01-14 13:23:05 EST 
*** cdt cvs genie on behalf of mkhouzam ***
Bug 333453: checkbox cleared when changing tab in remote application debug configuration

[*] RemoteCMainTab.java 1.3.4.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/cross/org.eclipse.cdt.launch.remote/src/org/eclipse/cdt/launch/remote/Attic/RemoteCMainTab.java?root=Tools_Project&r1=1.3&r2=1.3.4.1