Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333390

Summary:

[Compatibility] Workbench window selection does not appear to change immediately when active part switches

Product:

[Eclipse Project] e4

Reporter:

Remy Suen <remy.suen>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

VERIFIED FIXED

QA Contact:

Remy Suen <remy.suen>

Severity:

major

Priority:

CC:

daniel_megert, eiswind

Version:

1.0

Target Milestone:

4.1 M6

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
SelectionService patch v1	none
SelectionService patch v2	none

Description Remy Suen

2011-01-02 15:54:01 EST

From looking at the code, it seems that we appropriately detach/attach listeners based on the active part but don't actually send out a notification that the selection has changed (if one part's selection differs from another part's).

Comment 1 Remy Suen

2011-01-04 10:33:21 EST

Created attachment 186011 [details]
SelectionService patch v1

Comment 2 Remy Suen

2011-01-04 10:34:48 EST

(In reply to comment #1)
> Created attachment 186011 [details]
> SelectionService patch v1

Fix released to CVS HEAD. Thanks for the bug report, Thomas!

Comment 3 Remy Suen

2011-01-26 08:33:15 EST

Does not work with I20110125-2200 on Windows XP. It is okay in the inner but not the outer. Even if the inner only consists of plug-ins in the host target platform, the problem cannot be reproduced.

Comment 4 Remy Suen

2011-02-02 08:16:05 EST

Created attachment 188133 [details]
SelectionService patch v2

Can no longer reproduce on I20110125-2200 or I20110128-2000 for some reasons. Here's a patch which should ensure that the change in workbench window selection is propagated.

Comment 5 Remy Suen

2011-02-02 08:16:52 EST

(In reply to comment #4)
> Created attachment 188133 [details]
> SelectionService patch v2

Patch released to CVS HEAD.

Comment 6 Remy Suen

2011-03-08 14:13:07 EST

Verified with I20110307-2200 on Windows XP.