Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333338

Summary:	Linked File Resources are not handled correctly
Product:	[Technology] EGit	Reporter:	Michael Vorburger <mike>
Component:	Core	Assignee:	Project Inbox <egit.core-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse.org, hendrik, knut.wannheden, matthias.sohn, mpost, omax, qbasicer, thomas.mortagne, tomasz.zarna, vivien.tintillier
Version:	0.10.0
Target Milestone:	2.3
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:
Bug Depends on:
Bug Blocks:	388863

Description Michael Vorburger

2010-12-30 10:44:05 EST

On eGit 0.10.1 (which is not available in the Bugzilla Versions BTW) I've noticed that Linked File Resources are not yet handled correctly?

For example, on the MIFOS-4099__BetterWorkspace branch of my git@github.com:vorburger/mifos-head.git repo, in the mifos-parent folder/Eclipse project (https://github.com/vorburger/mifos-head/tree/MIFOS-4099__BetterWorkspace/mifos-parent), there are two linked file resources (pom.xml & pom.xml.readme.txt). -- BTW: What & how these are used for, if interested / relevant, is described in "Root directory (mifos-parent pom.xml) and Eclipse" on http://mifosforge.jira.com/wiki/display/~vorburger/WorkspaceSettings

eGit always shows those two files as Status Unknown - seeming to think they are files physically in the mifos-parent folder (when they are not; they are just Eclipse-level 'links' to the files one level up in the directory hiearchy).

Ideally, one would expect eGit to use the appropriate Eclipse workbench API and used the resolved location. Alternatively, a more minimal approach would be to have eGit ignore linked resources (for now).

Comment 1 Thomas Mortagne

2011-05-31 12:27:42 EDT

*** Bug 346381 has been marked as a duplicate of this bug. ***

Comment 2 François Rey

2011-06-05 19:09:02 EDT

I made two patches that should resolve this issue by ignoring linked resources.
These patches can be found attached to bug #347885 and bug #327407. They should also fix the apparently unreported case where the EGit project sharing dialog lists repositories totally unrelated to the selected project when it contains linked folders pointing to files below another git repository.

Note that Eclipse docs state it is recommended for a Team
Provider to ignore linked resources, see section titled "Strategies for Handling Linked Resources" there:
http://help.eclipse.org/help30/index.jsp?topic=/org.eclipse.platform.doc.isv/guide/team_resources.htm

Comment 3 François Rey

2011-06-07 19:31:56 EDT

I've submitted the following change request for this bug:
http://egit.eclipse.org/r/3680
It's a merging of the two patches mentioned above, plus some additions to cover a few more areas where linked resources should be ignored.

Comment 4 François Rey

2011-06-07 19:39:00 EDT

*** Bug 347885 has been marked as a duplicate of this bug. ***

Comment 5 Vivien Tintillier

2012-09-07 04:49:56 EDT

Is there anything blocking inclusion of the above patch? I see no negative comment on last gerrit patch set.

Comment 6 Matthias Sohn

2013-01-31 17:58:52 EST

merged as 199f7e89afbd2149c1809138204c7ac539a17b7e

Comment 7 Robin Rosenberg

2013-05-07 18:03:41 EDT

*** Bug 371967 has been marked as a duplicate of this bug. ***