Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333315

Summary:	Add text to Valgrind view when no errors were found
Product:	[Tools] Linux Tools	Reporter:	Elliott Baron <ebaron>
Component:	Valgrind	Assignee:	Elliott Baron <ebaron>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	jjohnstn, overholt, rafaelmt, wainersm
Version:	unspecified
Target Milestone:	0.9.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Elliott Baron

2010-12-29 15:28:56 EST

It can be confusing to just present an empty view to the user. We should instead give a message in the Valgrind view stating "No errors found".

Comment 1 Rafael Medeiros Teixeira

2011-08-08 14:17:32 EDT

I wrote a small patch for this bug. You can check it out at https://github.com/rafaelmt/linuxtools/commit/2b95573dcc7ed638e2515cbabf3fd1972ca34b6a .

Regards

Comment 2 Elliott Baron

2011-08-24 15:38:23 EDT

Excellent solution! Thanks for the patch.

Comment 3 Rafael Medeiros Teixeira

2011-08-30 09:06:14 EDT

(In reply to comment #2)
> Excellent solution! Thanks for the patch.

There's a case I missed in the first commit. Please take a look at this further fix:

https://github.com/rafaelmt/linuxtools/commit/31d303df92901c0f6d456ff8f4fa5bb5f07f161a

Regards

Comment 4 Elliott Baron

2011-08-30 18:48:41 EDT

Thanks for picking up on that Rafael. I've applied your revised patch to Git master.

Comment 5 Wainer dos Santos Moschetta

2011-09-19 10:01:48 EDT

(In reply to comment #4)
> Thanks for picking up on that Rafael. I've applied your revised patch to Git
> master.

Although target milestone is set to 0.9, will it be available first on 0.8.1?

Comment 6 Andrew Overholt

2011-09-30 16:12:30 EDT

In general one can trust the Target Milestone :)  In this particular case, the patch was applied only to master and not to stable-0.8 so it was not in 0.8.1.  

As a consumer, if there are specific bug fixes you'd like to see in a particular release, Wainer, I recommend you request such back-ports well before the release deadline so committers can plan accordingly.  I hope this will smooth the process for your consumption in the future.