Bugzilla – Full Text Bug Listing
| Summary: | [Theming] Move all SWT system color definitions to Display | ||
|---|---|---|---|
| Product: | [RT] RAP | Reporter: | Ralf Sternberg <rsternberg> |
| Component: | RWT | Assignee: | Project Inbox <rap-inbox> |
| Status: | NEW --- | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | ivan |
| Version: | 1.4 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
This would allow us to deprecate the Shell-Titlebar background-gradient-color, which never had an effect on the title bar gradient, but was only there to define a system property. This property is disturbing anyway, since background gradients can now be defined using background-image. *** Bug 434215 has been marked as a duplicate of this bug. *** |
The way SWT system colors are read from the theme is not quite consistent. Some colors have to be defined in the Display element, others on sub-widgets like List-Item or Shell-Titlebar, e.g.: Display { rwt-shadow-color: -> COLOR_WIDGET_NORMAL_SHADOW rwt-highlight-color: -> COLOR_WIDGET_HIGHLIGHT_SHADOW ... } Shell-Titlebar:inactive { background-color: -> COLOR_TITLE_INACTIVE_BACKGROUND background-gradient-color: -> COLOR_TITLE_INACTIVE_BACKGROUND_GRADIENT } As the method getSystemColor() is defined on Display, I think it would be more consistent to let all system colors be defined in the Display element.