Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333183

Summary: Export/Import Syntax Coloring settings
Product: [Tools] CDT Reporter: Gil Barash <scobido1984>
Component: cdt-editorAssignee: Anton Leherbauer <aleherb+eclipse>
Status: RESOLVED FIXED QA Contact: Anton Leherbauer <aleherb+eclipse>
Severity: enhancement    
Priority: P3 CC: cdtdoug, christophe.bismuth
Version: 8.0   
Target Milestone: 8.0   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch for adding Export/Import buttons
aleherb+eclipse: iplog-
TransferSettings for CDT syntax coloring
none
TransferSettings for CDT editor settings aleherb+eclipse: iplog+

Description Gil Barash CLA 2010-12-24 05:14:36 EST
Build Identifier:  I20100805-1700 ; CDT 8

It would be useful to allow exporting/importing the syntax coloring

(I know that this is a duplicate of bug 171674, but that bug doesn't seem to be opened correctly...)

Reproducible: Always
Comment 1 Gil Barash CLA 2010-12-24 05:16:57 EST
Created attachment 185804 [details]
Patch for adding Export/Import buttons
Comment 2 Anton Leherbauer CLA 2011-01-14 04:53:10 EST
(In reply to comment #1)
> Created attachment 185804 [details]
> Patch for adding Export/Import buttons

Thanks for the patch, but I think this should be covered by the generic Preferences Export/Import wizard.  What we could use is a preference group for the C/C++ Editor (and maybe other) preferences.  See extension point org.eclipse.ui.preferenceTransfer on how to define such a group.
Comment 3 Anton Leherbauer CLA 2011-01-14 04:53:33 EST
*** Bug 171674 has been marked as a duplicate of this bug. ***
Comment 4 Gil Barash CLA 2011-03-04 03:34:04 EST
Created attachment 190360 [details]
TransferSettings for CDT syntax coloring
Comment 5 Anton Leherbauer CLA 2011-03-04 05:36:26 EST
Thanks for the patch, I have a few suggestions:
1) Please externalize UI strings.
2) The key set of the Syntax Coloring group is incomplete, you need to consider
   suffixes like _bold, _italic, _strikethrough and _underline
3) The second group "C/C++ Editor Coloring Preferences" does not cover enough
   settings to be useful, also it might be confusing to have both "Coloring"
   preference groups.
   How about two groups "C/C++ Editor Appearance" and "C/C++ Editor Behavior",
   the first one comprising all color settings, the other the rest.
Comment 6 Gil Barash CLA 2011-03-05 16:12:02 EST
Created attachment 190477 [details]
TransferSettings for CDT editor settings

Hey Anton,

I've applied all the changes you suggested, here is a the fixed patch...
Comment 7 Anton Leherbauer CLA 2011-03-07 05:44:12 EST
> I've applied all the changes you suggested, here is a the fixed patch...

Thanks, I have committed the patch with a few changes:
- removed a few editor unrelated keys
- moved some keys from Appearance to Behavior (e.g. Scalability)
- added Doxygen preference keys
- use prefix matching where possible