| Summary: | Export/Import Syntax Coloring settings | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Gil Barash <scobido1984> | ||||||||
| Component: | cdt-editor | Assignee: | Anton Leherbauer <aleherb+eclipse> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Anton Leherbauer <aleherb+eclipse> | ||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | cdtdoug, christophe.bismuth | ||||||||
| Version: | 8.0 | ||||||||||
| Target Milestone: | 8.0 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Windows XP | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Gil Barash
Created attachment 185804 [details]
Patch for adding Export/Import buttons
(In reply to comment #1) > Created attachment 185804 [details] > Patch for adding Export/Import buttons Thanks for the patch, but I think this should be covered by the generic Preferences Export/Import wizard. What we could use is a preference group for the C/C++ Editor (and maybe other) preferences. See extension point org.eclipse.ui.preferenceTransfer on how to define such a group. *** Bug 171674 has been marked as a duplicate of this bug. *** Created attachment 190360 [details]
TransferSettings for CDT syntax coloring
Thanks for the patch, I have a few suggestions: 1) Please externalize UI strings. 2) The key set of the Syntax Coloring group is incomplete, you need to consider suffixes like _bold, _italic, _strikethrough and _underline 3) The second group "C/C++ Editor Coloring Preferences" does not cover enough settings to be useful, also it might be confusing to have both "Coloring" preference groups. How about two groups "C/C++ Editor Appearance" and "C/C++ Editor Behavior", the first one comprising all color settings, the other the rest. Created attachment 190477 [details]
TransferSettings for CDT editor settings
Hey Anton,
I've applied all the changes you suggested, here is a the fixed patch...
> I've applied all the changes you suggested, here is a the fixed patch...
Thanks, I have committed the patch with a few changes:
- removed a few editor unrelated keys
- moved some keys from Appearance to Behavior (e.g. Scalability)
- added Doxygen preference keys
- use prefix matching where possible
*** cdt cvs genie on behalf of aleherbau *** Bug 333183 - Export/Import Syntax Coloring settings [*] plugin.properties 1.210 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/plugin.properties?root=Tools_Project&r1=1.209&r2=1.210 [*] plugin.xml 1.397 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/plugin.xml?root=Tools_Project&r1=1.396&r2=1.397 [*] PreferenceConstants.java 1.64 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/PreferenceConstants.java?root=Tools_Project&r1=1.63&r2=1.64 |