Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333154

Summary:

Widget.isValidThread() should reuse the implementation of Display.isValidThread()

Product:

[RT] RAP

Reporter:

Florian Waibel <fwaibel>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

rsternberg

Version:

1.4

Target Milestone:

1.4 M5

Hardware:

All

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Patch containing the suggested reuse of Display.isValidThread	rsternberg: iplog+

Description Florian Waibel

2010-12-23 09:42:37 EST

The Widget class could delegate isValidThread to the Display class instead of implementing the compare operation itself.

Comment 1 Florian Waibel

2010-12-23 09:44:55 EST

Created attachment 185771 [details]
Patch containing the suggested reuse of Display.isValidThread

Comment 2 Ralf Sternberg

2010-12-28 10:26:51 EST

This patch looks good to me. It is a verbatim copy of the SWT code and also saves the acquisition of the deviceLock in Display#getThread() which apparently is unnecessary in this case.
Applied patch to CVS.