Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333129

Summary: "Show Files Included" failed
Product: [Tools] PTP Reporter: Victor Liu <victor1006>
Component: Remote ToolsAssignee: Vivian Kong <vivkong>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: cecco, g.watson, vivkong
Version: 4.0.5   
Target Milestone: 4.0.6   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
test data none

Description Victor Liu CLA 2010-12-23 00:47:57 EST
Created attachment 185744 [details]
test data

1. Download dcr_ex_f.rar under your home directory on the remote machine. Create a new remote project named "testProject" (Remote Provider: Remote tools, Project type: Empty project, Toolchains: Remote XL C/C++) on top of the "dcr_ex_f" folder 

2. Go to "Window" -> "Show View" -> "Other". In the Show View window, expand "Remote Development" and choose "Remote Include Browser" (if it is greyed out it means the view is already available).

3. In the Project Explorer view, open the project "testProject", drag and drop the source file "dcr3915f.cpp" into the Remote Include Browser view. Click on the "Show Files Included" button.

4. The Files Included view should include dcr3915f.h
Comment 1 Vivian Kong CLA 2011-01-24 11:54:56 EST
This fails when the Remote Tools connection's target name contains invalid URI characters (in my test case it was '_').  An IllegalArgumentException was thrown at SimpleLocationConverter.fromInternalFormat() when the CDTMiner needs to create an URI.  Since remote tools uses the target name as the hostname in the URI, it should have some validation machanism when a new Remote Tools connection is created in the New Remote Project wizard to avoid any invalid URI characters for hostnames.

When I created another remote tools connection with a valid hostname as the target name then I got the expected result from the Remote Include Browser.
Comment 2 Greg Watson CLA 2011-01-24 18:37:12 EST
Hi, a Remote Tools connection name should not be used for the host part of the authority component URI. It is not server-based, but rather registry-based where it is legal to have characters such as "_". The CDTMiner incorrectly assumes that a URI is always constructed using a server-based authority. This is also a problem in the CDT EFSExtensionProvider (see bug 326957) and RSE (see bug 287185.)
Comment 3 Vivian Kong CLA 2011-02-10 15:05:24 EST
*** Bug 332542 has been marked as a duplicate of this bug. ***
Comment 4 Vivian Kong CLA 2011-02-10 15:14:49 EST
URICreatorManager should now handle registry based URIs.

Fixed in ptp_4_0 and HEAD.
Comment 5 Vivian Kong CLA 2011-06-02 11:03:54 EDT
Forgot to assign it to myself