Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333081

Summary: Elements in the shared area gets displayed when switching to a perspective that shouldn't show the area
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact: Eric Moffatt <emoffatt>
Severity: major    
Priority: P3 CC: eiswind, emoffatt, gunnar, Lars.Vogel
Version: unspecified   
Target Milestone: 4.1 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
StackRenderer patch v1 none

Description Remy Suen CLA 2010-12-22 07:27:05 EST 
After the perspective dialog is closed, it seems that the system tries to grant activation to the active part again before the switch actually happens. We enqueue such a request and then perform the perspective switch.

When the switch is complete, we process the original activation request and since the element is found in the active perspective, we try to activate it. We should instead also check whether the element or its parents should be rendered in the current perspective before we make such an activation request.
Comment 1 Remy Suen CLA 2010-12-22 07:34:35 EST 
Created attachment 185701 [details]
StackRenderer patch v1

Add a check to the activation request processing to verify that the element and its parents should be rendered before we actually activate the part.
Comment 2 Thomas Kratz CLA 2010-12-22 07:54:18 EST 
Works for me. Thanks Remy.
Comment 3 Remy Suen CLA 2010-12-22 10:56:11 EST 
(In reply to comment #2)
> Works for me. Thanks Remy.

Thanks for checking, Thomas.

Eric, please review. Perhaps the isValid(MUIElement) method should be declared in the EModelService or something.
Comment 4 Thomas Kratz CLA 2011-02-26 02:15:36 EST 
Still happens on M5
Comment 5 Remy Suen CLA 2011-03-07 14:37:28 EST 
(In reply to comment #1)
> Created attachment 185701 [details]
> StackRenderer patch v1

Fix released to HEAD with copyright header updates and an addition inlined comment.

Thanks for the bug report, Thomas! Sorry for not releasing this earlier.