Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333050

Summary: Hyperlinks don't work inside macros (regression)
Product: [Tools] CDT Reporter: Marc-André Laperle <malaperle>
Component: cdt-editorAssignee: Sergey Prigogin <eclipse.sprigogin>
Status: RESOLVED FIXED QA Contact: Anton Leherbauer <aleherb+eclipse>
Severity: major    
Priority: P3 CC: cdtdoug, eclipse.sprigogin, yevshif
Version: 7.0.2   
Target Milestone: 7.0.2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Macro Hyperlink patch eclipse.sprigogin: iplog+

Description Marc-André Laperle CLA 2010-12-21 20:48:24 EST 
Tested:
-8.0.0.201011290012 (not working)
-8.0.0.201012211206 (not working)
-7.0.1.201009141542 (working)


#define TEST 1
#define TEST2 TEST

Hold Ctrl and hover on TEST, no hyperlink is available. Maybe caused by the fix in bug 326418?
Comment 1 Marc-André Laperle CLA 2011-01-13 01:08:11 EST 
Created attachment 186707 [details]
Macro Hyperlink patch

The hyperlink detector was using a fallback that got removed recently. This fallback was useful for this case. Since the new hyperlink detector has now a more complete fallback when the ast is not available, I made a change so that this fallback is also used if the ast is available but did not detect an hyperlink.

This has been a major issue for me using CDT in my daily. If possible, I would really like to see this fixed for 7.0.2.
Comment 2 Marc-André Laperle CLA 2011-01-13 19:01:53 EST 
Hi Sergey. Since you made the recent changes to the hyperlink detector, can I ask your opinion on this?
Comment 3 Sergey Prigogin CLA 2011-01-13 19:52:28 EST 
I'll take a look at the patch.
Comment 4 Sergey Prigogin CLA 2011-01-13 20:38:42 EST 
(In reply to comment #0)
> Tested:
> -8.0.0.201011290012 (not working)
> -8.0.0.201012211206 (not working)
> -7.0.1.201009141542 (working)
> 
> 
> #define TEST 1
> #define TEST2 TEST
> 
> Hold Ctrl and hover on TEST, no hyperlink is available. Maybe caused by the fix
> in bug 326418?

It's a bigger problem than just hyperlink detection. F3 navigation and occurrences finder don't work either.
Comment 5 Marc-André Laperle CLA 2011-01-13 21:30:30 EST 
(In reply to comment #4)
> It's a bigger problem than just hyperlink detection. F3 navigation and
> occurrences finder don't work either.

Hmmm, F3 works for me, but occurrences don't work in 6.0.2 and 7.0.0 either.
Comment 6 Sergey Prigogin CLA 2011-01-13 21:43:48 EST 
I don't know why F3 navigation didn't work for me when I tried it first time.
It works now.

Fixed in HEAD and cdt_7_0 > 20110113.
Comment 7 Marc-André Laperle CLA 2011-01-13 22:11:14 EST 
(In reply to comment #6)
> Fixed in HEAD and cdt_7_0 > 20110113.

Excellent, thank you!