Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333025

Summary:

Allow additional JVM arguments through ICustomAnalysisProvider extension point

Product:

z_Archived

Reporter:

Joel Cayne <jcayne>

Component:

TPTP

Assignee:

Joel Cayne <jcayne>

Status:

CLOSED FIXED

QA Contact:

Kathy Chan <kathy>

Severity:

normal

Priority:

CC:

jgwest, mikereid

Version:

unspecified

Flags:

mikereid: review+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch for additional JVM arguments	none
Patch for additional JVM arguments	none
Patch to use a list for ProcessParameters	none

Description Joel Cayne

2010-12-21 10:49:25 EST

The ICustomAnalysisProvider extension point allows for additional JVMTI arguments to be passed to a launch command. It could be updated to allow for additional JVM arguments to be appended to the launch command.

Comment 1 Joel Cayne

2010-12-21 10:50:41 EST

Created attachment 185643 [details]
Patch for additional JVM arguments

Comment 2 Joel Cayne

2010-12-21 13:17:34 EST

Created attachment 185656 [details]
Patch for additional JVM arguments

Updated to exclude empty Strings for JVM arguments.

Comment 3 Joel Cayne

2010-12-21 13:32:18 EST

Mike,
Can you please review the patch?

Thanks!

Comment 4 Mike Reid

2010-12-21 13:44:50 EST

Patch looks good.

Comment 5 Kathy Chan

2010-12-21 13:58:00 EST

Approved for 4.7.2.

Comment 6 Joel Cayne

2010-12-21 17:22:45 EST

Patch checked into HEAD with project lead approval.

I added that quotes should be included around the JVM arguments if there is a space to the comment for the new method in ICustomAnalysisProvider.

Comment 7 Joel Cayne

2010-12-22 17:24:48 EST

Re-opening to update getVMArg to use a List for the extra JVM arguments.

Comment 8 Joel Cayne

2010-12-22 17:25:39 EST

Created attachment 185740 [details]
Patch to use a list for ProcessParameters

Comment 9 Mike Reid

2010-12-23 11:20:47 EST

New patch using List<String> looks good.

Comment 10 Jonathan West

2010-12-23 11:23:09 EST

Updated patch approved for 4.7.2.

Comment 11 Joel Cayne

2010-12-23 14:51:47 EST

Patch checked into HEAD.

Comment 12 Joel Cayne

2011-01-17 09:26:23 EST

Closing.