Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 333005

Summary:

Customized External Browser is not used

Product:

z_Archived

Reporter:

Roy Ganor <ganoro>

Component:

ATF

Assignee:

Inbox <atf.core-inbox>

Status:

NEW ---

QA Contact:

Severity:

normal

Priority:

CC:

jacek.pospychala

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
patch	none

Description Roy Ganor

2010-12-21 07:05:31 EST

1. In preferences select External browser and change the system default browser
2. Open a browser 

Expected - the specified browser is opened
Actual - the system browser is opened

Comment 1 Roy Ganor

2010-12-21 07:05:56 EST

Created attachment 185626 [details]
patch

Comment 2 Jacek Pospychala

2010-12-21 09:39:02 EST

I don't like the iexplore path editing. Can't we simply use "iexplore.exe"? It should always be on path.
I don't know what is returned by BrowserManager.getCurrentWebBrowser(). It will return browser selected by user, yes?
I also don't understand this change:

+		} else {
+			if ((style & IWorkbenchBrowserSupport.AS_VIEW) != 0)
+				webBrowser = new InternalBrowserViewInstance(browserId, style,
+						name, tooltip);
+			else
+				webBrowser = new InternalBrowserEditorInstance(browserId,
+						style, name, tooltip);
+		}

does it mean that in some circumstances, the Platform's internal browser will be used?