Bugzilla – Full Text Bug Listing
| Summary: | [EOL] 'and' and 'or' operators have the same precedence | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Epsilon | Reporter: | Antonio Garcia-Dominguez <agarcdomi> | ||||||||
| Component: | Core | Assignee: | Dimitris Kolovos <dkolovos> | ||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | ||||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | --- | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 185448 [details]
Patch with an acceptance test case that illustrates the issue
I would also suggest that the precedence of the operators is documented in the Epsilon book. Created attachment 185449 [details]
Fixed version of 185448 without ANSI escape sequences
Created attachment 185450 [details]
Simple EOL script showing the precedence of 'or', 'and' and '='
The operator '=' (which deprecated ':=' as assignment operator a few releases ago, IIRC) also seems to have a wrong precedence. Normally, the assignment operator is always last, but according to the grammar, it has the same precedence as the relational operators. The ':=' and '::=' operators work fine, though.
I have attached a simple EOL script which illustrates these problems.
By the way, I think I got the order of the logicalExpression rules wrong: it's the other way around. Like this:
expressionStatement
: logicalExpressionImplies ';'!
;
logicalExpressionImplies
: logicalExpressionOr ('implies'^ logicalExpressionOr
{if (root_0.getToken() != null) root_0.getToken().setType(OPERATOR);})*
;
logicalExpressionOr
: logicalExpressionAnd (('or'|'xor')^ logicalExpressionAnd
{if (root_0.getToken() != null) root_0.getToken().setType(OPERATOR);})*
;
logicalExpressionAnd
: relationalExpression ('and'^ relationalExpression
{if (root_0.getToken() != null) root_0.getToken().setType(OPERATOR);})*
;
Have any of these changes made it into the latest version of the EOL grammar in the SVN? No, I have neither tested nor integrated these changes yet. (In reply to comment #5) > The operator '=' (which deprecated ':=' as assignment operator a few > releases ago, IIRC) also seems to have a wrong precedence. Normally, the > assignment operator is always last, but according to the grammar, it has the > same precedence as the relational operators. The ':=' and '::=' operators > work fine, though. The = issue has been fixed in r2195. Changing the precedence of operators at this stage could (rather inconspicuously) break existing code so I'd be inclined to keep it as-is. Closing as fixed but please feel free to reopen if needed. Fixed in the latest interim version (1.0.0.201304211529). Fixed in 1.1 |
Build Identifier: 20100917-0705 Normally, a Java or C programmer would expect this expression to yield "true": true or false and false However, in Epsilon it is being evaluated to "false". Apparently, it is being interpreted as (true or false) and false instead of true or (false and false) The problem appears to be in the grammar itself (EolParserRules.g). 'and', 'or', 'xor' and 'implies' are all lumped together: expressionStatement : logicalExpression ';'! ; logicalExpression : relationalExpression (('or'|'and'|'xor'|'implies')^ relationalExpression {if (root_0.getToken() != null) root_0.getToken().setType(OPERATOR);})* ; In order to make EOL consistent with most programming languages, I would suggest that logical operators are divided into three levels of precedence: and, or+xor, and implies. Perhaps something like this would work. Please note that it is untested. I have been unable to run the "Build EOL Parser" launchers in the o.e.epsilon.eol.engine, as I'm using GNU/Linux and I can't find the o.e.epsilon.antlr.dev project anywhere in the source code :-/. expressionStatement : logicalExpressionAnd ';'! ; logicalExpressionAnd : logicalExpressionOr ('and'^ logicalExpressionOr {if (root_0.getToken() != null) root_0.getToken().setType(OPERATOR);})* ; logicalExpressionOr : logicalExpressionImplies (('or'|'xor')^ logicalExpressionImplies {if (root_0.getToken() != null) root_0.getToken().setType(OPERATOR);})* ; logicalExpressionImplies : relationalExpression ('implies'^ relationalExpression {if (root_0.getToken() != null) root_0.getToken().setType(OPERATOR);})* ; Reproducible: Always Steps to Reproduce: 1. Run the EOL script in the patch. 2. Check the output in the console.