Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332853

Summary:	Fix some FindBugs warnings
Product:	[Tools] MAT	Reporter:	Andrew Johnson <andrew_johnson>
Component:	Core	Assignee:	Project Inbox <mat.core-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	krum.tsvetkov
Version:	1.1
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Andrew Johnson

2010-12-17 09:57:45 EST

The Tycho/Maven build raises some FindBugs warnings.

We should fix some of these.
E.g.
https://hudson.eclipse.org/hudson/view/Tycho%20+%20Maven/job/tycho-mat-nightly/188/findbugsResult/HIGH/package.1457113920/type.37768831/

Comment 1 Andrew Johnson

2010-12-17 10:11:43 EST

Fixed missing throw in the ClassLoaderExplorerQuery using bug 327433 as that bug is still in assigned state.

Fixed dead store in HashEntriesQuery.

Comment 2 Andrew Johnson

2010-12-17 11:25:40 EST

Fixed a redundant comparison in OQL.
No need to compare a double against +0 and -0, and even a comparison with -0.0 would be unnecessary.
Should NaN be treated as false or true?

Comment 3 Krum Tsvetkov

2010-12-23 03:56:20 EST

Not sure about this one. We can leave it as it is (false) until we find a reason to change it.

Comment 4 Andrew Johnson

2011-06-30 11:50:03 EDT

Find bugs showed a problem where the notes file was written in UTF8 but read in the default encoding.
UTF8 is best as the notes files get moved from machine to machine.

Comment 5 Andrew Johnson

2013-02-01 06:51:16 EST

Should we upgrade to the latest plug-in 2.5.2 with FindBugs 2.0 ?
http://mojo.codehaus.org/findbugs-maven-plugin/

Comment 6 Krum Tsvetkov

2013-02-01 09:47:28 EST

Let's give it a try. I'm just trying if building locally works and will them submit the change.

Comment 7 Andrew Johnson

2013-11-11 11:35:08 EST

Fix reliance on default file encoding for HPROF and IBM acquire dumps - we now force the file encoding on the executable and use the same encoding when reading the result of the command.

Comment 8 Krum Tsvetkov

2015-06-26 03:25:32 EDT

I think this one is finished. Let's open further tickets if we have concrete issues, instead of keeping this one forever.