Bugzilla – Full Text Bug Listing
| Summary: | Compiler warnings in N20101216-2000 build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Equinox | Reporter: | Olivier Thomann <Olivier_Thomann> | ||||||
| Component: | Compendium | Assignee: | John Ross <jwross> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | aniefer, tjwatson | ||||||
| Version: | 3.7 | ||||||||
| Target Milestone: | 3.7 M5 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
I don't understand these warnings. It looks to me that the @SuppressWarnings("hiding") are needed. My preference would be to change the code to rename local vars to not hide other vars though.
John could you provide a patch to rename the vars in question?
Olivier, is there a jdt bug here? When I remove the @SuppressWarnings("hiding")
from the code jdt gives a warning in the editor, but the build seems to think there is no hiding going on.
hiding warning might not be set up inside pde.build. I'll investigate. I think you might need this line in the build.properties: javacWarnings..=+hiding since the hiding warnings are disabled by default. (In reply to comment #3) > I think you might need this line in the build.properties: > javacWarnings..=+hiding > since the hiding warnings are disabled by default. Thanks Olivier, I prefer to fix the code to eliminate the the need for this. It is not important, but I am still confused why the +hiding would be needed in the build.properties. Shouldn't the annotations be recognized anyway? They are recognized. But since the corresponding warning level is off by default, there is no warning to suppress and therefore you get a warning that it is not necessary. (In reply to comment #1) > John could you provide a patch to rename the vars in question? Syntax error. "John" is an ambiguous name reference. Please use resolved names or add an appropriate qualified name on the CC list. I thought that pde.build was matching the same level of warnings directly inside the build.xml file. Andrew, should not this work for free ? (In reply to comment #6) > (In reply to comment #1) > > John could you provide a patch to rename the vars in question? > > Syntax error. "John" is an ambiguous name reference. Please use resolved names > or add an appropriate qualified name on the CC list. Sorry John Arthorne! :-) Yes this is meant for John Ross. Assigning to John Ross to make it clear. Created attachment 185441 [details]
Patch 1
Removes all @SuppressWarnings("hiding").
Note that if you examine the patch manually, you will see a full replacement of the contents of the two affected files, even though I only modified a few lines. The Create Patch wizard simply refuses to identify only the contents that actually changed. This is only happening with the new org.eclipse.equinox.coordinator project I just pulled from the repo.
However, if you use Apply Patch, you will only see what actually changed.
Perhaps this is normal behavior and you're wondering why I'm even bothering to mention it. It's just something I've never experienced and seems strange.
Created attachment 185443 [details]
Patch 2
Contains only what changed.
Thanks John R. for the patch! |
1. WARNING in /src/org/eclipse/equinox/coordinator/CoordinationImpl.java (at line 85) @SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding") 2. WARNING in /src/org/eclipse/equinox/coordinator/CoordinationImpl.java (at line 311) private void validateName(@SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding") 1. WARNING in /src/org/eclipse/equinox/coordinator/CoordinatorImpl.java (at line 126) @SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding") 2. WARNING in /src/org/eclipse/equinox/coordinator/CoordinatorImpl.java (at line 151) @SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding") 3. WARNING in /src/org/eclipse/equinox/coordinator/CoordinatorImpl.java (at line 165) @SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding") 4. WARNING in /src/org/eclipse/equinox/coordinator/CoordinatorImpl.java (at line 222) @SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding") 5. WARNING in /src/org/eclipse/equinox/coordinator/CoordinatorImpl.java (at line 239) @SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding") 6. WARNING in /src/org/eclipse/equinox/coordinator/CoordinatorImpl.java (at line 258) @SuppressWarnings("hiding") Unnecessary @SuppressWarnings("hiding")