Bugzilla – Full Text Bug Listing
| Summary: | [Refactoring] Convert Spec Stmt to Decl Attrib (Alternate) [Contrib] | ||
|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | Abhi23 <abhisheksharma523> |
| Component: | Photran.Refactoring Engine | Assignee: | Abhi23 <abhisheksharma523> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P2 | CC: | com-eclipse-dot-org, kim462, leong1, yongseoklee1 |
| Version: | 6.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X - Carbon (unsup.) | ||
| Whiteboard: | |||
| Attachments: | |||
Thanks for the contribution! There are a few minor changes I'd like you to make before I can accept this. Please resubmit the patch with the following changes: 1. The copyright headers for the new Java files need to be changed. Copyright should be ascribed to the four of you as individuals, not to UIUC, since this was not a work for hire. Similarly, the "initial API and implementation" line should have your names, not UIUC. 2. Please add a brief (one or two sentence) summary to the JavaDoc comment for each class. 3. The @author tags for ConvertSpecificationStatementToDeclarationAttributeAction and ConvertSpecificationStatementToDeclarationAttributeInputPage need to have the authors' full names. 4. If you have time, please format the Java code similarly to the other refactoring classes. Mostly, this means putting opening braces on the next line and making sure there's a space between "if" or "while" and the opening parenthesis. (You should be able to use the Source > Format menu item to do this, but if you do, please scan over the code to make sure the formatter didn't do anything unseemly.) You have done this in some places but not others. Obviously, I haven't had time to fully try your code yet, but these changes will be sufficient to start the IP review process. Also, for the IP review, I will need *each* of you (Joe Leong, Abhishek Sharma, YongSeok Lee, and Justin Kim) to individually confirm (as a comment on this bug) that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files. For extra credit in CS427, I will need to have the revised patch and all four confirmations on this bug by noon today (Friday, 12/17) -- that's when I'm submitting EC to Ralph. That's a really tight deadline... I hope you can make it. But even if you can't make the extra credit deadline, I'd still be happy to accept your code into Photran, if you're still interested. Created attachment 185403 [details]
Convert specification statement to declaration attriute
Changes made to Javadocs, author statement, header, formatting
(In reply to comment #1) > Thanks for the contribution! There are a few minor changes I'd like you to > make before I can accept this. Please resubmit the patch with the following > changes: > > 1. The copyright headers for the new Java files need to be changed. Copyright > should be ascribed to the four of you as individuals, not to UIUC, since this > was not a work for hire. Similarly, the "initial API and implementation" line > should have your names, not UIUC. > > 2. Please add a brief (one or two sentence) summary to the JavaDoc comment for > each class. > > 3. The @author tags for > ConvertSpecificationStatementToDeclarationAttributeAction and > ConvertSpecificationStatementToDeclarationAttributeInputPage need to have the > authors' full names. > > 4. If you have time, please format the Java code similarly to the other > refactoring classes. Mostly, this means putting opening braces on the next > line and making sure there's a space between "if" or "while" and the opening > parenthesis. (You should be able to use the Source > Format menu item to do > this, but if you do, please scan over the code to make sure the formatter > didn't do anything unseemly.) You have done this in some places but not > others. > > Obviously, I haven't had time to fully try your code yet, but these changes > will be sufficient to start the IP review process. > > Also, for the IP review, I will need *each* of you (Joe Leong, Abhishek Sharma, > YongSeok Lee, and Justin Kim) to individually confirm (as a comment on this > bug) that > > 1. you wrote 100% of the code without incorporating content from elsewhere or > relying on the intellectual property of others, Abhishek - I confirm that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others. > 2. you have the right to contribute the code to Eclipse, and Abhishek- I have the right to contribute the code to Eclipse > 3. you have included the EPL license header in all source files? Abhishek- I have included the EPL license header in all source files. (In reply to comment #3) > (In reply to comment #1) > > Thanks for the contribution! There are a few minor changes I'd like you to > > make before I can accept this. Please resubmit the patch with the following > > changes: > > > > 1. The copyright headers for the new Java files need to be changed. Copyright > > should be ascribed to the four of you as individuals, not to UIUC, since this > > was not a work for hire. Similarly, the "initial API and implementation" line > > should have your names, not UIUC. > > > > 2. Please add a brief (one or two sentence) summary to the JavaDoc comment for > > each class. > > > > 3. The @author tags for > > ConvertSpecificationStatementToDeclarationAttributeAction and > > ConvertSpecificationStatementToDeclarationAttributeInputPage need to have the > > authors' full names. > > > > 4. If you have time, please format the Java code similarly to the other > > refactoring classes. Mostly, this means putting opening braces on the next > > line and making sure there's a space between "if" or "while" and the opening > > parenthesis. (You should be able to use the Source > Format menu item to do > > this, but if you do, please scan over the code to make sure the formatter > > didn't do anything unseemly.) You have done this in some places but not > > others. > > > > Obviously, I haven't had time to fully try your code yet, but these changes > > will be sufficient to start the IP review process. > > > > Also, for the IP review, I will need *each* of you (Joe Leong, Abhishek Sharma, > > YongSeok Lee, and Justin Kim) to individually confirm (as a comment on this > > bug) that > > > > 1. you wrote 100% of the code without incorporating content from elsewhere or > > relying on the intellectual property of others, > Abhishek - I confirm that I wrote 100% of the code without incorporating > content from elsewhere or relying on the intellectual property of others. > > 2. you have the right to contribute the code to Eclipse, and > Abhishek- I have the right to contribute the code to Eclipse > > 3. you have included the EPL license header in all source files? > Abhishek- I have included the EPL license header in all source files. (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #1) > > > Thanks for the contribution! There are a few minor changes I'd like you to > > > make before I can accept this. Please resubmit the patch with the following > > > changes: > > > > > > 1. The copyright headers for the new Java files need to be changed. Copyright > > > should be ascribed to the four of you as individuals, not to UIUC, since this > > > was not a work for hire. Similarly, the "initial API and implementation" line > > > should have your names, not UIUC. > > > > > > 2. Please add a brief (one or two sentence) summary to the JavaDoc comment for > > > each class. > > > > > > 3. The @author tags for > > > ConvertSpecificationStatementToDeclarationAttributeAction and > > > ConvertSpecificationStatementToDeclarationAttributeInputPage need to have the > > > authors' full names. > > > > > > 4. If you have time, please format the Java code similarly to the other > > > refactoring classes. Mostly, this means putting opening braces on the next > > > line and making sure there's a space between "if" or "while" and the opening > > > parenthesis. (You should be able to use the Source > Format menu item to do > > > this, but if you do, please scan over the code to make sure the formatter > > > didn't do anything unseemly.) You have done this in some places but not > > > others. > > > > > > Obviously, I haven't had time to fully try your code yet, but these changes > > > will be sufficient to start the IP review process. > > > > > > Also, for the IP review, I will need *each* of you (Joe Leong, Abhishek Sharma, > > > YongSeok Lee, and Justin Kim) to individually confirm (as a comment on this > > > bug) that > > > > > > 1. you wrote 100% of the code without incorporating content from elsewhere or > > > relying on the intellectual property of others, Abhishek - I confirm that I wrote 100% of the code without incorporating Yong - I confirm that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others. > > > 2. you have the right to contribute the code to Eclipse, and Abhishek- I have the right to contribute the code to Eclipse Yong- I have the right to contribute the code to Eclipse > > > 3. you have included the EPL license header in all source files? Abhishek- I have included the EPL license header in all source files. Yong -I have included the EPL license header in all source files. (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #1) > > > > Thanks for the contribution! There are a few minor changes I'd like you to > > > > make before I can accept this. Please resubmit the patch with the following > > > > changes: > > > > > > > > 1. The copyright headers for the new Java files need to be changed. Copyright > > > > should be ascribed to the four of you as individuals, not to UIUC, since this > > > > was not a work for hire. Similarly, the "initial API and implementation" line > > > > should have your names, not UIUC. > > > > > > > > 2. Please add a brief (one or two sentence) summary to the JavaDoc comment for > > > > each class. > > > > > > > > 3. The @author tags for > > > > ConvertSpecificationStatementToDeclarationAttributeAction and > > > > ConvertSpecificationStatementToDeclarationAttributeInputPage need to have the > > > > authors' full names. > > > > > > > > 4. If you have time, please format the Java code similarly to the other > > > > refactoring classes. Mostly, this means putting opening braces on the next > > > > line and making sure there's a space between "if" or "while" and the opening > > > > parenthesis. (You should be able to use the Source > Format menu item to do > > > > this, but if you do, please scan over the code to make sure the formatter > > > > didn't do anything unseemly.) You have done this in some places but not > > > > others. > > > > > > > > Obviously, I haven't had time to fully try your code yet, but these changes > > > > will be sufficient to start the IP review process. > > > > > > > > Also, for the IP review, I will need *each* of you (Joe Leong, Abhishek Sharma, > > > > YongSeok Lee, and Justin Kim) to individually confirm (as a comment on this > > > > bug) that > > > > > > > > 1. you wrote 100% of the code without incorporating content from elsewhere or > > > > relying on the intellectual property of others, > > Abhishek - I confirm that I wrote 100% of the code without incorporating > Yong - I confirm that I wrote 100% of the code without incorporating > content from elsewhere or relying on the intellectual property of others. Joseph- I confirm that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others. > > > > > 2. you have the right to contribute the code to Eclipse, and > > Abhishek- I have the right to contribute the code to Eclipse > Yong- I have the right to contribute the code to Eclipse Joseph- I have the right to contribute the code to Eclipse > > > > > 3. you have included the EPL license header in all source files? > Abhishek- I have included the EPL license header in all source files. > Yong -I have included the EPL license header in all source files. Joseph- I have included the EPL license header in all source files. -Joseph Leong Beomjun (Justin) Kim - I confirm that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others. Beomjun (Justin) Kim - I have the right to contribute the code to Eclipse Beomjun (Justin) Kim - I have included the EPL license header in all source files. (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > (In reply to comment #1) > > > > > Thanks for the contribution! There are a few minor changes I'd like you to > > > > > make before I can accept this. Please resubmit the patch with the following > > > > > changes: > > > > > > > > > > 1. The copyright headers for the new Java files need to be changed. Copyright > > > > > should be ascribed to the four of you as individuals, not to UIUC, since this > > > > > was not a work for hire. Similarly, the "initial API and implementation" line > > > > > should have your names, not UIUC. > > > > > > > > > > 2. Please add a brief (one or two sentence) summary to the JavaDoc comment for > > > > > each class. > > > > > > > > > > 3. The @author tags for > > > > > ConvertSpecificationStatementToDeclarationAttributeAction and > > > > > ConvertSpecificationStatementToDeclarationAttributeInputPage need to have the > > > > > authors' full names. > > > > > > > > > > 4. If you have time, please format the Java code similarly to the other > > > > > refactoring classes. Mostly, this means putting opening braces on the next > > > > > line and making sure there's a space between "if" or "while" and the opening > > > > > parenthesis. (You should be able to use the Source > Format menu item to do > > > > > this, but if you do, please scan over the code to make sure the formatter > > > > > didn't do anything unseemly.) You have done this in some places but not > > > > > others. > > > > > > > > > > Obviously, I haven't had time to fully try your code yet, but these changes > > > > > will be sufficient to start the IP review process. > > > > > > > > > > Also, for the IP review, I will need *each* of you (Joe Leong, Abhishek Sharma, > > > > > YongSeok Lee, and Justin Kim) to individually confirm (as a comment on this > > > > > bug) that > > > > > > > > > > 1. you wrote 100% of the code without incorporating content from elsewhere or > > > > > relying on the intellectual property of others, > > > > Abhishek - I confirm that I wrote 100% of the code without incorporating > > Yong - I confirm that I wrote 100% of the code without incorporating > > content from elsewhere or relying on the intellectual property of others. > Joseph- I confirm that I wrote 100% of the code without incorporating content > from elsewhere or relying on the intellectual property of others. > > > > > > > 2. you have the right to contribute the code to Eclipse, and > > > > Abhishek- I have the right to contribute the code to Eclipse > > Yong- I have the right to contribute the code to Eclipse > Joseph- I have the right to contribute the code to Eclipse > > > > > > > 3. you have included the EPL license header in all source files? > > Abhishek- I have included the EPL license header in all source files. > > Yong -I have included the EPL license header in all source files. > Joseph- I have included the EPL license header in all source files. > > -Joseph Leong Beomjun (Justin) Kim - I confirm that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others. Beomjun (Justin) Kim - I have the right to contribute the code to Eclipse Beomjun (Justin) Kim - I have included the EPL license header in all source files. (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > (In reply to comment #3) > > > > (In reply to comment #1) > > > > > Thanks for the contribution! There are a few minor changes I'd like you to > > > > > make before I can accept this. Please resubmit the patch with the following > > > > > changes: > > > > > > > > > > 1. The copyright headers for the new Java files need to be changed. Copyright > > > > > should be ascribed to the four of you as individuals, not to UIUC, since this > > > > > was not a work for hire. Similarly, the "initial API and implementation" line > > > > > should have your names, not UIUC. > > > > > > > > > > 2. Please add a brief (one or two sentence) summary to the JavaDoc comment for > > > > > each class. > > > > > > > > > > 3. The @author tags for > > > > > ConvertSpecificationStatementToDeclarationAttributeAction and > > > > > ConvertSpecificationStatementToDeclarationAttributeInputPage need to have the > > > > > authors' full names. > > > > > > > > > > 4. If you have time, please format the Java code similarly to the other > > > > > refactoring classes. Mostly, this means putting opening braces on the next > > > > > line and making sure there's a space between "if" or "while" and the opening > > > > > parenthesis. (You should be able to use the Source > Format menu item to do > > > > > this, but if you do, please scan over the code to make sure the formatter > > > > > didn't do anything unseemly.) You have done this in some places but not > > > > > others. > > > > > > > > > > Obviously, I haven't had time to fully try your code yet, but these changes > > > > > will be sufficient to start the IP review process. > > > > > > > > > > Also, for the IP review, I will need *each* of you (Joe Leong, Abhishek Sharma, > > > > > YongSeok Lee, and Justin Kim) to individually confirm (as a comment on this > > > > > bug) that > > > > > > > > > > 1. you wrote 100% of the code without incorporating content from elsewhere or > > > > > relying on the intellectual property of others, > > > > Abhishek - I confirm that I wrote 100% of the code without incorporating > > Yong - I confirm that I wrote 100% of the code without incorporating > > content from elsewhere or relying on the intellectual property of others. > Joseph- I confirm that I wrote 100% of the code without incorporating content > from elsewhere or relying on the intellectual property of others. Beomjun (Justin) Kim - I confirm that I wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others. > > > > > > > 2. you have the right to contribute the code to Eclipse, and > > > > Abhishek- I have the right to contribute the code to Eclipse > > Yong- I have the right to contribute the code to Eclipse > Joseph- I have the right to contribute the code to Eclipse Beomjun (Justin) Kim - I have the right to contribute the code to Eclipse > > > > > > > 3. you have included the EPL license header in all source files? > > Abhishek- I have included the EPL license header in all source files. > > Yong -I have included the EPL license header in all source files. > Joseph- I have included the EPL license header in all source files. > > -Joseph Leong Beomjun (Justin) Kim - I have included the EPL license header in all source files. Thanks. Abhishek, it looks like the revised patch (accidentally) includes some of your hired work -- notably, ChangeSubroutineToFunctionTestSuite and HighlightText -- which is copyrighted by UIUC. Please resubmit the patch with those files excluded, since they are not part of this project (and including them would cause problems during the IP review). Thanks. Created attachment 185410 [details]
Convert specification statement to declaration attriute
patch corrected
*** Bug 332813 has been marked as a duplicate of this bug. *** Unfortunately, there is no longer active development on this component. |
Created attachment 185393 [details] Refactoring to convert spec statement to declaration attributes This refactoring converts any specification to a declaration attribute whenever possible. The specification is added as attribute is added and statement is deleted