Bugzilla – Full Text Bug Listing
| Summary: | FacetedProjectWizard class bug | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Common Tools | Reporter: | Lee Wang-soo <hivemind02> | ||||||
| Component: | Faceted Project Framework | Assignee: | Konstantin Komissarchik <konstantin> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | Konstantin Komissarchik <konstantin> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | ccc | ||||||
| Version: | 3.2.2 | ||||||||
| Target Milestone: | 3.2.3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 7 | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
(In reply to comment #0) There is mistake. Above modified code should be as following: IPath locationPath = null; if (!firstPage.useDefaults()) { // when not using default location locationPath = this.firstPage.getLocationPath(); } fpjwc.setProjectLocation(locationPath); When using default project location (workspace location), locationPath should be null. Lee, are you able to create a patch for this? Attaching a proposed patch helps more than simply putting the code change into a bug comment. Created attachment 185469 [details]
patch for fixing 33286 bug
Created attachment 185470 [details]
simple plugin project for test patch
You can test patch by run "Extends FPWizard" New Project Wizard in others category.
Comment on attachment 185469 [details]
patch for fixing 33286 bug
Thanks for the patch and the test plugin.
Released fix to 3.2.3, 3.3.0 and fproj branch. |
Build Identifier: M20100909-0800 I've created new wizard by extending org.eclipse.wst.common.project.facet.ui.FacetedProjectWizard. When my new wizard does finish, error 'Invalid project description' occurred and project creations fails. I look the code in FactedProjectWizard, and found the code cause error: @Override public IWizardPage getNextPage( final IWizardPage page ) { if( page == this.firstPage ) { final IFacetedProjectWorkingCopy fpjwc = getFacetedProjectWorkingCopy(); fpjwc.setProjectName( this.firstPage.getProjectName() ); fpjwc.setProjectLocation( this.firstPage.getLocationPath() ); } return super.getNextPage( page ); } last line: fpjwc.setProjectLocation( this.firstPage.getLocationPath() ); should be modified to IPath locationPath = null; if (firstPage.useDefaults()) { locationPath = this.firstPage.getLocationPath(); } fpjwc.setProjectLocation(locationPath); When using default project location (workspace location), locationPath should be null. Reproducible: Always