Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332766

Summary: Promote from the GMF Builds page is broken
Product: [Modeling] Modeling Reporter: Anthony Hunter <ahunter.eclipse>
Component: RelengAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 Flags: ahunter.eclipse: indigo+
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch to fix the issue. none

Description Anthony Hunter CLA 2010-12-16 11:58:13 EST 
There is a bug in the GMF promote script that prevents you from promoting a build from the build web page.

There is a workaround that you can run the promote from the command line on modeling.eclipse.org. I have been using this workaround since February.

Since the workaround involves editing a text file and then running the promote, it would be useful to actually spend the time and fix the bug. The painful part is that Nick Boldt wrote these scripts and he does not do modeling builds anymore. Debugging 2000 lines of build script is not in my top ten favorite things to do today though.
Comment 1 Anthony Hunter CLA 2010-12-16 12:00:58 EST 
(In reply to comment #0)
> Since the workaround involves editing a text file and then running the promote,
> it would be useful to actually spend the time and fix the bug. The painful part
> is that Nick Boldt wrote these scripts and he does not do modeling builds
> anymore. Debugging 2000 lines of build script is not in my top ten favorite
> things to do today though.

I wrote this in an internal problem report. Given the issue is not going away, I spent the time to debug the issue.

The issue is resolved in the /modeling/build/promo-common.php script. So moving this bug to modeling releng. I will attach a patch.
Comment 2 Anthony Hunter CLA 2010-12-16 12:03:55 EST 
Created attachment 185345 [details]
Patch to fix the issue.

The current promo-common.php does not have the logic for the restructured GMF projects. Attached is a patch.

I added if/else to make the code more readable.

The patch has already been applied to /var/www/html/modeling/build/promo-common.php on modeling.eclipse.org .
Comment 3 Anthony Hunter CLA 2011-01-26 15:25:03 EST 
Committed to HEAD.