Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332754

Summary:

[Help] Problems in help tray with focus in main dialog area

Product:

[Eclipse Project] Platform

Reporter:

Markus Keller <markus.kell.r>

Component:

User Assistance

Assignee:

Chris Goldthorpe <cgold>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

Version:

3.7

Target Milestone:

3.7 M5

Hardware:

OS:

Windows 7

Whiteboard:

Bug Depends on:

127852

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Markus Keller

2010-12-16 11:03:09 EST

Follow-up to bug 127852

- org.eclipse.help.ui.internal.views.ContextHelpPart#updateTitle(Control) calls
#computeSearchTerms(Control), which always starts looking for a title in the
the parent of the passed control. When the dialog shell has focus, the code
misses the obvious target. After bug 127852 is fixed, the scenario from
bug 127852 comment 12 cannot be reproduced any more, but the problem should be fixed anyway.

- org.eclipse.help.ui.internal.views.HelpTray.createActions()... calls "shell.setFocus();" (on line line 85).
That was a workaround for a bug in TrayDialog#closeTray(), see
bug 127852 comment 12. This line should be removed now that bug 127852 has been fixed.

Comment 1 Chris Goldthorpe

2011-01-05 17:05:08 EST

Created attachment 186133 [details]
Patch

I agree with the suggestions, this patch implements both.

Comment 2 Chris Goldthorpe

2011-01-05 17:06:28 EST

Patch committed to HEAD. Fixed.