Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332748

Summary:	Extensions for org.eclipse.pde.ui.samples require that plug-in is unpacked
Product:	[Eclipse Project] PDE	Reporter:	Stephan Herrmann <stephan.herrmann>
Component:	UI	Assignee:	PDE-UI-Inbox <pde-ui-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Vikas.Chandra
Version:	3.7	Keywords:	investigate
Target Milestone:	---
Hardware:	Other
OS:	Linux
Whiteboard:	stalebug

Description Stephan Herrmann

2010-12-16 10:25:30 EST

We (Object Teams) ship some examples using the extension point
org.eclipse.pde.ui.samples.

The sample projects are contained in our sample plug-in and we
specify the zip-location using the samples->project->archive attribute 
of the extension.

However, this only works if we ship the containing plug-in with
  unpack="true"
which is discouraged specifically for the simultaneous release.

Currently, this bug is the only reason why we have to specify unpack=true.

FYI, when I try to say unpack=false working with the example fails with
the following exception:

java.util.zip.ZipException: error in opening zip file
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:114)
at java.util.zip.ZipFile.<init>(ZipFile.java:75)
at org.eclipse.pde.internal.ui.samples.SampleOperation.getZipFileFromPluginDir(SampleOperation.java:194)
at org.eclipse.pde.internal.ui.samples.SampleOperation.importProject(SampleOperation.java:146)
at org.eclipse.pde.internal.ui.samples.SampleOperation.access$3(SampleOperation.java:108)
at org.eclipse.pde.internal.ui.samples.SampleOperation$1.run(SampleOperation.java:75)

Obviously, getZipFileFromPluginDir is not a good idea if the plugin is a jar.

Comment 1 Lars Vogel

2019-09-24 13:59:45 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 2 Stephan Herrmann

2019-09-24 14:33:46 EDT

(In reply to Lars Vogel from comment #1)
> This bug hasn't had any activity in quite some time. Maybe the problem got
> resolved, was a duplicate of something else, or became less pressing for
> some reason - or maybe it's still relevant but just hasn't been looked at
> yet.
> 
> If you have further information on the current state of the bug, please add
> it. The information can be, for example, that the problem still occurs, that
> you still want the feature, that more information is needed, or that the bug
> is (for whatever reason) no longer relevant.

Don't you recall bug 501120? After the revert in that bug (phew!) no relevant changes have happened in this area.

Ergo: nothing has improved, but given the low interest in that feature I'm not holding my breath for fixes.

Comment 3 Eclipse Genie

2021-09-15 01:06:58 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 4 Eclipse Genie

2023-09-06 12:16:43 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.