Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332739

Summary:	Internal error when pasting a malformed location for CVS Repository
Product:	[Eclipse Project] Platform	Reporter:	Tomasz Zarna <tomasz.zarna>
Component:	CVS	Assignee:	platform-cvs-inbox <platform-cvs-inbox>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.7
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Tomasz Zarna

2010-12-16 09:03:57 EST

I20101214-0800

Steps:
1. Open CVS Repositories view
2. Right click, New > Repository location
3. Paste: ":pserver:selvi@<ip-address>:" (taken from bug 326762)
=> Error log:

org.eclipse.team.internal.ccvs.core.CVSException: Invalid CVS repository location format: :pserver:selvi@<ip-address>:
	at org.eclipse.team.internal.ccvs.core.connection.CVSRepositoryLocation.fromString(CVSRepositoryLocation.java:238)
	at org.eclipse.team.internal.ccvs.ui.wizards.ConfigurationWizardMainPage$1.handleEvent(ConfigurationWizardMainPage.java:162)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1058)
	at org.eclipse.swt.widgets.Combo.wmCommandChild(Combo.java:2413)
	at org.eclipse.swt.widgets.Control.WM_COMMAND(Control.java:4302)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4168)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4904)
	at org.eclipse.swt.internal.win32.OS.CallWindowProcW(Native Method)
	at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2368)
	at org.eclipse.swt.widgets.Combo.callWindowProc(Combo.java:300)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4256)
	at org.eclipse.swt.widgets.Combo.windowProc(Combo.java:2124)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4904)
	at org.eclipse.swt.internal.win32.OS.CallWindowProcW(Native Method)
	at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2368)
	at org.eclipse.swt.widgets.Combo.callWindowProc(Combo.java:305)
	at org.eclipse.swt.widgets.Combo.windowProc(Combo.java:2095)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4904)
	at org.eclipse.swt.internal.win32.OS.CallWindowProcW(Native Method)
	at org.eclipse.swt.internal.win32.OS.CallWindowProc(OS.java:2368)
	at org.eclipse.swt.widgets.Combo.callWindowProc(Combo.java:300)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4256)
	at org.eclipse.swt.widgets.Combo.windowProc(Combo.java:2124)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4904)
	at org.eclipse.swt.internal.win32.OS.SendMessageW(Native Method)
	at org.eclipse.swt.internal.win32.OS.SendMessage(OS.java:3162)
	at org.eclipse.swt.widgets.Combo.paste(Combo.java:1057)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
	at java.lang.reflect.Method.invoke(Method.java:600)
	at org.eclipse.ui.internal.handlers.WidgetMethodHandler.execute(WidgetMethodHandler.java:151)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:468)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:786)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:885)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:567)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:508)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:123)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1254)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1066)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1103)
	at org.eclipse.swt.widgets.Combo.sendKeyEvent(Combo.java:1319)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1099)
	at org.eclipse.swt.widgets.Widget.wmChar(Widget.java:1508)
	at org.eclipse.swt.widgets.Combo.wmChar(Combo.java:2296)
	at org.eclipse.swt.widgets.Combo.windowProc(Combo.java:2049)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4891)
	at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2465)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3673)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.team.internal.ccvs.ui.repo.RepositoriesView$4.run(RepositoriesView.java:187)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4084)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3675)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:48)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
	at java.lang.reflect.Method.invoke(Method.java:600)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Contains: Location must have form ':methodname:[user[:password]@]host:[port]/path/to/cvsroot'
Contains: Error in port specification

An error should be displayed on the page, but no error should be logged to the Error Log.

Comment 1 Tomasz Zarna

2010-12-16 09:08:45 EST

When a string like ":pserver:selvi@127.0.0.1:/" is pasted, an error about the ending "/" gets displayed. When removed, the error message disappears but the "Finish" button is still disabled. There is no information why the user cannot proceed.

Comment 2 Tomasz Zarna

2010-12-17 07:10:41 EST

Weird, not able to reproduce today. Marking as invalid, will go back to it, if it happens again.