Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332732

Summary: SCMURL needs to default project name if not given
Product: [Eclipse Project] Platform Reporter: Alex Blewitt <alex.blewitt>
Component: TeamAssignee: Tomasz Zarna <tomasz.zarna>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ankur_sharma, pwebster
Version: 3.7   
Target Milestone: 3.7 M5   
Hardware: PC   
OS: All   
URL: http://wiki.eclipse.org/PDE/Importing_SCMURLs
Whiteboard:
Attachments:
Description Flags
Fix v01
none
mylyn/context/zip
none
Fix v02 none

Description Alex Blewitt CLA 2010-12-16 08:23:47 EST
Since Maven SCM URLs are common in the web, but won't have any OSGi-type attributes like 'tag' or 'project', it's important that we default to sensible values all attributes that aren't specified. An earlier vesrion of the code did this, but has regressed due to recent fix of bug 326926.

In the case of an SCM URL without a project, it should default to the last slash-separated element of the SCM URL itself. This maps to the common behaviour of having the project name as the fileysystem name.

Eclipse-SourceReferences: scm:cvs:pserver:me@example.com:/cvsroot:/bundles/com.example.superwidget -> project=com.example.superwidget, tag=HEAD*
Eclipse-SourceReferences: scm:svn+ssh://example.com/svnroot/project/trunk/bundles/com.example.superwidget -> project=com.example.superwidget

The tag should be specific to the type of version control system.
Comment 1 Tomasz Zarna CLA 2010-12-17 06:56:07 EST
Created attachment 185414 [details]
Fix v01
Comment 2 Tomasz Zarna CLA 2010-12-17 06:56:09 EST
Created attachment 185415 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2010-12-22 10:46:41 EST
Created attachment 185718 [details]
Fix v02

Updated javadoc + 2 more junits.
Comment 4 Tomasz Zarna CLA 2010-12-22 10:49:13 EST
Fix v02 applied to HEAD. Available in builds >=N20101222-2000.
Comment 5 Tomasz Zarna CLA 2011-01-25 11:40:48 EST
The changes are tagged with I20110104-0800. Verified by code inspection in I20110124-1800.