Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332712

Summary:	After creating the skeleton e4-Application with the wizward provided by E4 Tools the generated projects doesn't work because of missing Addons etc
Product:	z_Archived	Reporter:	Marc Teufel <marc.teufel>
Component:	E4	Assignee:	Project Inbox <e4.runtime-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	pwebster, tom.schindl
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Marc Teufel

2010-12-16 05:13:32 EST

Build Identifier: 0.11m4 / 4.1m4

The e4 Application Wizard from E4 Tools needs to be updated:

- Since M4 every e4-Application needs Addon-Entries (see list below) in their Application.e4xmi - Its necessary to extend the e4 Application Wizard from E4 Tools so that the missing Addons will be in the model automatically. Otherwise its not possible to start the generated application. 
For me its also not clear, whats the idea behind addons? Why do we need this?

- In the generated Code there is a SaveHandler.java generated. This file makes use of org.eclipse.e4.core.di.IDisposable wich seems to be removed from the e4 framework. SaveHandler.java needs to be updated also (remove the import, remove the if with check if instance of IDisposable).

- When I create a new e4 App with the wizard and uncheck to create an Activator, alls the generated Handlers (AboutHandler, OpenHandler, ...) have a wrong package specification (.handlers). 


The list of Addons to be added into a Model automatically by the wizard:


<addons xmi:id="_utI-wAj3EeC_v8_ApTXv4g" elementId="org.eclipse.e4.core.commands.service" contributionURI="platform:/plugin/org.eclipse.e4.core.commands/org.eclipse.e4.core.commands.CommandServiceAddon"/>

<addons xmi:id="_vB1cYAj3EeC_v8_ApTXv4g" elementId="org.eclipse.e4.ui.workbench.commands.model" contributionURI="platform:/plugin/org.eclipse.e4.ui.workbench/org.eclipse.e4.ui.internal.workbench.addons.CommandProcessingAddon"/>

<addons xmi:id="_4NEncAj4EeC_v8_ApTXv4g" elementId="org.eclipse.e4.ui.contexts.service" contributionURI="platform:/plugin/org.eclipse.e4.ui.services/org.eclipse.e4.ui.services.ContextServiceAddon"/>

<addons xmi:id="_FoviYAj5EeC_v8_ApTXv4g" elementId="org.eclipse.e4.ui.workbench.contexts.model" contributionURI="platform:/plugin/org.eclipse.e4.ui.workbench/org.eclipse.e4.ui.internal.workbench.addons.ContextProcessingAddon"/>

<addons xmi:id="_TK11cAj5EeC_v8_ApTXv4g" elementId="org.eclipse.e4.ui.bindings.service" contributionURI="platform:/plugin/org.eclipse.e4.ui.bindings/org.eclipse.e4.ui.bindings.BindingServiceAddon"/>

<addons xmi:id="_XcQnUAj5EeC_v8_ApTXv4g" elementId="org.eclipse.e4.ui.workbench.bindings.model" contributionURI="platform:/plugin/org.eclipse.e4.ui.workbench.swt/org.eclipse.e4.ui.workbench.swt.util.BindingProcessingAddon"/>


Reproducible: Always

Steps to Reproduce:
see Details

Comment 1 Thomas Schindl

2010-12-17 04:52:23 EST

fixed in HEAD >= 20101217 - I once more like to question the manual additions of those Addon-Elements. I really think this is an extremly bad idea because we know that applications not adding them are not working.

Comment 2 Paul Webster

2010-12-17 08:28:58 EST

(In reply to comment #1)
> fixed in HEAD >= 20101217 - I once more like to question the manual additions
> of those Addon-Elements. I really think this is an extremly bad idea because we
> know that applications not adding them are not working.

I just got a bug because someone included org.eclipse.ui.workbench to get some classes ... and their app didn't start because it used extensions to add things to the model that could not possibly be used in an e4 app.

We can still go either way with this.  i.e. Our way only (have the extension add the Addon elements) or flexible RCP support (have the product that defines the model define them).

PW