Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332701

Summary: startup fails due to NPE in E4Workbench
Product: [Eclipse Project] e4 Reporter: Steffen Pingel <steffen.pingel>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: aniefer, pwebster, remy.suen
Version: unspecified   
Target Milestone: 4.1 M4   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Steffen Pingel CLA 2010-12-16 01:59:05 EST
After updating to M4 e4 fails to startup. I only get the error below in the log. Starting with a clean workspace did not make any difference.

!SESSION 2010-12-15 22:53:22.253 -----------------------------------------------
eclipse.buildId=I20101214-1429
java.version=1.6.0_22
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_CA

!ENTRY org.eclipse.osgi 4 0 2010-12-15 22:53:27.405
!MESSAGE Application error
!STACK 1
java.lang.NullPointerException
        at org.eclipse.e4.ui.internal.workbench.E4Workbench.processHierarchy(E4Workbench.java:205)
        at org.eclipse.e4.ui.internal.workbench.E4Workbench.init(E4Workbench.java:117)
        at org.eclipse.e4.ui.internal.workbench.E4Workbench.<init>(E4Workbench.java:72)
        at org.eclipse.e4.ui.internal.workbench.swt.E4Application.createE4Workbench(E4Application.java:264)
        at org.eclipse.ui.internal.Workbench$3.run(Workbench.java:523)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:516)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1386)
Comment 1 Paul Webster CLA 2010-12-16 08:19:58 EST
(In reply to comment #0)
> After updating to M4 e4 fails to startup. I only get the error below in the
> log. Starting with a clean workspace did not make any difference.

Is it your e4 app?

If so, you might need the add-ons listed in https://bugs.eclipse.org/bugs/show_bug.cgi?id=332712

PW
Comment 2 Remy Suen CLA 2010-12-16 09:32:12 EST
(In reply to comment #0)
> After updating to M4 e4 fails to startup.

We have confirmed I20101214-1429 to be a problem. The 4.1M4 build should be I20101213-1225 though (which works). Thanks for the heads-up, Steffen, we've been down in 3.x code so haven't been looking at our 4.x builds.

Note that we are considering a respin at the moment.
http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg05099.html
Comment 3 Paul Webster CLA 2010-12-16 09:54:13 EST
(In reply to comment #2)
> 
> Note that we are considering a respin at the moment.
> http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg05099.html

Will this problem effect the re-spin, or is it related to Andrew's test build of 4.1 then e4?

PW
Comment 4 Remy Suen CLA 2010-12-16 10:48:30 EST
As a sanity check, the I20101214-1429 build does contain the correct org.eclipse.ui.workbench bundle with the newly added compatibility classes.
Comment 5 Steffen Pingel CLA 2010-12-16 10:56:42 EST
Sorry, I just assumed that it was M4 but I updated to whatever p2 suggested to me which apparently was a later bulid. I fixed it for myself by downloading the M4 release version which indeed worked.
Comment 6 Remy Suen CLA 2010-12-16 11:05:08 EST
The cause is due to the LegacyIDE.e4xmi file in the plugins/org.eclipse.platform folder not having the ContextProcessingAddon listed. The file size of my Monday build's xmi file and my Tuesday build's xmi file is different.

Andrew, my fresh unzip of the I20101214-1429 indicates that it is indeed missing (at least) the aforementioned XML element noted above. So it's certainly not some kind of renegade save/persist problem.

The folder is named org.eclipse.platform_4.1.0.v20101125-1630 but our last change to the xmi file was delivered this month, so the 1125 seems incorrect here.

(In reply to comment #5)
> Sorry, I just assumed that it was M4 but I updated to whatever p2 suggested to
> me which apparently was a later bulid.

No problems. It's great that you tested this build for us, Steffen. Thanks. :)
Comment 7 Andrew Niefer CLA 2010-12-16 11:16:27 EST
(In reply to comment #5)
> Sorry, I just assumed that it was M4 but I updated to whatever p2 suggested to
> me which apparently was a later bulid. I fixed it for myself by downloading the
> M4 release version which indeed worked.

This is my fault for not realizing that my tests would show up and hide M4 from everyone.  I raised bug 332759
Comment 8 Andrew Niefer CLA 2010-12-16 11:17:16 EST
I have also removed I20101214-1429 from the public repository.
Comment 9 Andrew Niefer CLA 2010-12-16 11:49:36 EST
Ok, this test build was based on a branched builder, the platform bundle was tagged after the builder was branched and I missed synchronizing that map file.  The org.eclipse.sdk feature was also out of date.

I have fixed this so the next build should be good.  Marking the bug fixed since I have also removed the bad build from the update site.