Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332686

Summary:	[backport][Browser] Search for external browser in Preferences finds > 40 instances of firefox on Ubuntu 64bit, if started in /usr/bin
Product:	[Eclipse Project] Platform	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	User Assistance	Assignee:	platform-ua-inbox <platform-ua-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	cgold, michael.vaneikeren, mober.at+eclipse, ob1.eclipse, wb-rel
Version:	3.5.1
Target Milestone:	3.6.2
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:	293159
Bug Blocks:

Description Martin Oberhuber

2010-12-15 15:42:21 EST

Requesting a backport of the fix for bug #293159 to Eclipse 3.6.2.

The patch from bug 293159 should apply cleanly, and bundle version should not need updating since a backport has already happened on ui.browser through
bug 330927.

Thanks!

Comment 1 Chris Goldthorpe

2010-12-15 19:13:27 EST

I think this can go into 3.6.2. Martin - which platforms have you tested the patch on so far? Although the bug was reported on Linux we need to test that Windows and MacOS still work correctly.

Comment 2 Martin Oberhuber

2010-12-16 00:47:15 EST

I tested Ubuntu only. I don't have a Mac. I _could_ test other Linux distros, Windows and Solaris as soon as I get hold of a 3.7 I-build that has the change.

Though I'm having a hard time thinking of anything that could possibly go wrong... in the worst case, the "getCanonicalPath" behaves oddly when doing a manual "Search for Browser"... but then, very similar code has been in place for  bug 187318 and bug 285804 for a while without issues that I'm aware of. And, the change is limited to the "Search for Browser" wizard only so it's very targeted.

Is there a Unittest for the "Search for Browser" functionality?

Comment 3 Chris Goldthorpe

2010-12-16 13:28:01 EST

There is no Unit test for search for browser. I can test on the Mac and Windows.

Comment 4 Chris Goldthorpe

2010-12-16 16:25:28 EST

I tested on Windows and Mac and everything worked fine. Patch applied to 3.6 maintenance stream.