Bugzilla – Full Text Bug Listing
| Summary: | [EditorMgmt] DefaultPartList leaks shells | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Remy Suen <remy.suen> | ||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | daniel_megert | ||||
| Version: | 3.1 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | stalebug | ||||||
| Bug Depends on: | 335566 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Remy Suen
Created attachment 185231 [details]
DefaultPartList patch v1
Dispose the shell instead of making it when it gets deactivated.
(In reply to comment #1) > Created an attachment (id=185231) [details] > DefaultPartList patch v1 Fix released to CVS HEAD. Verified by source inspection with I20110124-1800. 1. Open an editor. 2. Ctrl+E 3. Alt+Tab to another window. 4. Alt+Tab back to Eclipse. 5. Ctrl+E does nothing. It may be that the disposal is causing issues with the source providers. I'll rollback this change tomorrow. (In reply to comment #1) > Created attachment 185231 [details] > DefaultPartList patch v1 Change rolled back due to comment 4. Will look at this again later. (In reply to comment #4) > 1. Open an editor. > 2. Ctrl+E > 3. Alt+Tab to another window. > 4. Alt+Tab back to Eclipse. > 5. Ctrl+E does nothing. > > It may be that the disposal is causing issues with the source providers. This is not related to source providers. The problem is that the focus is not returned to styled text (no caret) though Caret.setFocus() is called. This looks like an SWT issue to me. A possible ugly workaround would be to do the dispose in an asyncExec. (In reply to comment #6) > The problem is that the focus is not > returned to styled text (no caret) though Caret.setFocus() is called. This > looks like an SWT issue to me. Thanks for investigating, Dani! This is quite interesting. Perhaps I can draw up a snippet that will reproduce the problem. > A possible ugly workaround would be to do the > dispose in an asyncExec. Indeed. I tried this while I was verifying that comment 4 was caused by this change and the asyncExec workaround does work. (In reply to comment #6) > The problem is that the focus is not > returned to styled text (no caret) though Caret.setFocus() is called. I have opened bug 335566 for this problem. *** This bug has been marked as a duplicate of bug 335566 *** (In reply to comment #9) > *** This bug has been marked as a duplicate of bug 335566 *** Actually Dani, I would like to keep this bug open. If SWT fixes the problem, I still need to deliver attachment 185231 [details] back to HEAD so that the shell is actually disposed. (In reply to comment #10) > (In reply to comment #9) > > *** This bug has been marked as a duplicate of bug 335566 *** > > Actually Dani, I would like to keep this bug open. Yes, of course: me too. I wanted to mark it as depends on, but obviously was to fast/lazy. Verified that comment 4 is no logger bugged with I20110127-2034 on Windows XP. Not clear if SWT will fix bug 335566 for 3.7. Unsetting the target milestone. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant please remove the stalebug whiteboard tag. |