Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332621

Summary:

ctl-click on source entries produces Unhandled event loop exception

Product:

[Tools] Linux Tools

Reporter:

Ben Konrath <ben>

Component:

ChangeLog

Assignee:

Jeff Johnston <jjohnstn>

Status:

VERIFIED FIXED

QA Contact:

Severity:

major

Priority:

CC:

jjohnstn, linux.changelog-inbox, overholt

Version:

unspecified

Target Milestone:

0.8.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
stack trace from error	none

Description Ben Konrath

2010-12-15 07:09:26 EST

Build Identifier: 20100917-0705

Ctl-click on source entries produces an Unhandled event loop exception and the source file is not opened. See attached stack trace. Here are the plugins I have installed:

org.eclipse.linuxtools.changelog.core (2.6.7.201008261754)
org.eclipse.linuxtools.changelog.cparser (2.6.3.201008261754)
org.eclipse.linuxtools.changelog.doc (2.6.4.201008261754)
org.eclipse.linuxtools.changelog.parsers.java (2.6.3.201008261754)

Reproducible: Always

Steps to Reproduce:
1. import this project: http://gitorious.org/online-glom/java-libglom
2. open ChangeLog file
3. ctl-click on src/examples/org/glom/libglom/examples/ExampleDocumentLoad.java
4. see exception and file does not open

Comment 1 Ben Konrath

2010-12-15 07:10:34 EST

Created attachment 185219 [details]
stack trace from error

Comment 2 Jeff Johnston

2011-01-27 11:47:30 EST

(In reply to comment #1)
> Created attachment 185219 [details]
> stack trace from error

I was able to reproduce the problem.  In my case, I imported the git project outside of Eclipse and then I create a Java project that pointed to this out-of-workspace location.

The problem is that ChangeLog builds the location using the WorkspaceRoot.  This results in /my/workspace/path/projectName/src/etc...

However, when looking for this file, the Eclipse API checks each project and gets it location.  The location of the git project is reported correctly out-of-workspace (e.g. /tmp/mygitarea).

The APU compares the file path it is looking for to see if any project is a prefix of the location.  This doesn't occur so it returns null so when we try and ctrl-click it is passing a null path which is wrong.

Comment 3 Jeff Johnston

2011-01-27 15:21:49 EST

Fixed in trunk.

Comment 4 Ben Konrath

2011-02-01 03:54:42 EST

Thanks Jeff! Will this fix be released in a version that can be used with Eclipse 3.6?

Comment 5 Jeff Johnston

2011-02-01 14:19:26 EST

(In reply to comment #4)
> Thanks Jeff! Will this fix be released in a version that can be used with
> Eclipse 3.6?

It should be in the updates-helios-nightly repository for linux tools:

http://download.eclipse.org/technology/linuxtools/updates-helios-nightly

Comment 6 Ben Konrath

2011-02-02 04:48:24 EST

(In reply to comment #5)
> It should be in the updates-helios-nightly repository for linux tools:
> 
> http://download.eclipse.org/technology/linuxtools/updates-helios-nightly

It doesn't seem to be there. Is there someplace else I can look? Thanks.

Comment 7 Andrew Overholt

2011-02-02 10:23:33 EST

http://download.eclipse.org/technology/linuxtools/updates-nightly-helios/

Comment 8 Ben Konrath

2011-02-02 12:39:16 EST

I'm using the latest ChangeLog Plugin from the Helios Linux Tools Nightly update site and I'm still seeing the problem. Here's the version I'm using:

 ChangeLog Management Tools (Incubation)	2.7.0.201101281810	org.eclipse.linuxtools.changelog.feature.group

Comment 9 Jeff Johnston

2011-02-02 18:07:37 EST

(In reply to comment #8)
> I'm using the latest ChangeLog Plugin from the Helios Linux Tools Nightly
> update site and I'm still seeing the problem. Here's the version I'm using:
> 
>  ChangeLog Management Tools (Incubation)    2.7.0.201101281810   
> org.eclipse.linuxtools.changelog.feature.group

Ok, I think I found the problem.  The last Helios build in question was using a map file from a tagged release instead of the branch and the fix was made after the tag was generated.  I have started a new build which should appear in the same update location.

Comment 10 Ben Konrath

2011-02-03 05:10:15 EST

Thanks, it's working.