Bugzilla – Full Text Bug Listing
| Summary: | JspParser parsing incorrectly for few pieces of code in jsp. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Rakesh <rakes123> | ||||
| Component: | jst.jsp | Assignee: | Rakesh <rakes123> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Nick Sandonato <nsand.dev> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | thatnitind | ||||
| Version: | unspecified | Flags: | nsand.dev:
review+
|
||||
| Target Milestone: | 3.2.3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
This is happening due to patch of Bug 325818.I added a check to take care of related scenarios. It is '(embeddedList.size() >=2'.I didn't think of possibilty that this function assembleEmbeddedContainer() would be called recursively , and this check fails for such scenarios. This check should be done only for latest function call(topmost on recursive stack), right now it taking size of embeddedList into consideration which is wrong. I have changed it take only latest call into consideration. It is a one line change. I have tested that all the things that were mentioned in Bug 325818 are fine. Created attachment 185220 [details]
patch
Hi Nick,which set of tests do you rely on to check for JspParser.I see way too many tests failing in 'org.eclipse.jst.jsp.core.tests', with or without patch.
Looks appropriate. Thanks, Rakesh. |
Build Identifier: M20101201-0800 Add this line of code in a jsp file(just to test parsing). '<c:out value='<td nowrap height="${sitenav.navtabSelImgSize[1][0]}" style="background-image: url(\'${sitenav.navtabSelImg[1]}\')"></td>' escapeXml='false'/>' '"></td>' escapeXml='false'/>', this piece is parsed incorrectly. Reproducible: Always