Bugzilla – Full Text Bug Listing
| Summary: | buckminster.build.id property not inserted into p2 metadata | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Michal Ruzicka <michal.ruza> | ||||
| Component: | Buckminster | Assignee: | buckminster.core-inbox <buckminster.core-inbox> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | Kenn.Hussey | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 185218 [details]
org.eclipse.buckminster.pde-follow_upstream_change.patch
The attached patch fixes to issue simply by overriding the method which replaced the deprecated one.
the patch was committed in revision 11623, to the helios-maintenance branch of the project |
Buckminster used to insert buckminster.build.id property into p2 metadata it generated for bundles which contained about.mappings files referencing the build id by means of the @build@ placeholder. Recent Buckminster does not do that any more. The problem seems to be caused by a change in p2 API - the following function is apparently deprecated (and no longer called): //TODO remove this method protected void org.eclipse.equinox.p2.publisher.eclipse.BundlesAction.generateBundleIUs(BundleDescription[] bundleDescriptions, IPublisherResult result, IProgressMonitor monitor) { generateBundleIUs(bundleDescriptions, null, result, monitor); } And since it is this function which is overridden in Buckminster (by org.eclipse.buckminster.pde.tasks.BundlesAction.generateBundleIUs) to add the buckminster.build.id p2 publishing property advice it is obvious why the property is not being added any more.