Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332612

Summary: Incorrect argument passed to isSupervised in ResourceVariantTreeSubscriber.members(IResource)
Product: [Eclipse Project] Platform Reporter: Wojciech Galanciak <wojciech.galanciak>
Component: TeamAssignee: Wojciech Galanciak <wojciech.galanciak>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: kazm, tomasz.zarna
Version: 3.7   
Target Milestone: 3.7 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 327785    
Attachments:
Description Flags
fix tomasz.zarna: iplog+

Description Wojciech Galanciak CLA 2010-12-15 06:11:05 EST 
In org.eclipse.team.core.variants.ResourceVariantTreeSubscriber.members(IResource) there is an iteration over all members of a resource which was passed as an argument for this method. It is performed to remove deletion conflicts and unsupervised resources from members list. I have found an incorrect condition:
if (!isSupervised(resource))
In result, if resource is not supervised all its members will be removed. It should be:
if (!isSupervised(member)).
Comment 1 Wojciech Galanciak CLA 2010-12-15 06:16:27 EST 
Created attachment 185214 [details]
fix
Comment 2 Tomasz Zarna CLA 2010-12-15 09:48:13 EST 
Fixed in HEAD, available in builds >=N20101215-2000. Thanks Wojtek.
Comment 3 Tomasz Zarna CLA 2011-01-25 11:46:39 EST 
The change is tagged with I20101221-0800 (and with tags that came later). Verified by code inspection in I20110124-1800.