Bugzilla – Full Text Bug Listing
| Summary: | merge o.e.m.reviews.tasks.core and o.e.m.reviews.core models | ||
|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> |
| Component: | Mylyn | Assignee: | Project Inbox <mylyn-triaged> |
| Status: | CLOSED MOVED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | alvaro.sanchez-leon, kilian.matt, sebastien.dubois |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Steffen Pingel
Kilian, any thoughts on this? Ok I've basically rewritten the model, but I still have an EMF based model(xtext) for the storage of the review files. I'll try to merge this model with the framework model. I ended up creating a copy of the model for Gerrit since I needed to evolve it and wasn't sure if anyone was already depending on the framework model. The packages are already in the org.eclipse.mylyn.reviews.core namespace and have a proper internal/API split. Kilian, could you take a look? Is there a task that describes the Xtext related changes? I am just curious to what extend that provides an advantage over serializing the EMF model directly using the built-in peristence support. Unfortunatly I did not create a task for that. The advantage of xtext is that I have a textual description of the model, which can be serialized into the description(scope) and the comments (results). Example Task-description: Review scope: Resource from Attachment "319357_show_hide_sections.diff" by "Jane@inso.tuwien.ac.at" on "2010-08-04 18:53:00" of task 85 Comment: Review result: PASSED Comment: "ok looks good" Thats much simpler than having binary attachments containing xml and allows any user, with no reviews installed to see the result in the comments. I plan however to replace that Xtext parts with an own ANTLR parser implementation, as I'm not happy about having that dependency. Can you create a new task? I think that's an interesting an idea and would like to follow the discussion around it. Note that Xtext will be chaning API for Indigo: http://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg05233.html Is it possible to make Xtext/ANTLR work with the existing model or does that mean TBR will necessarily have it's own model? If it helps we can consider offline support for Mylyn attachments even though I think the "natural" language approach is kind of cool. Yes that's also possible to base an Xtext grammar on an existing EMF model, and I was going to implement that. I think that the common review navigator of bug 334967 would work on the common model, so it's pretty mandatory to implement this. I'm still planning to replace that Xtext stuff with an custom parser so we can get rid of that dependency. I was thinking to implement some basic offline support for outgoing attachments - so that I can create a new task and include the attachments right away - is that feasible? > I was thinking to implement some basic offline support for outgoing attachments > - so that I can create a new task and include the attachments right away - is > that feasible? Yes, we could support that on API level to allow the Reviews project to take advantage of it. We can discuss on bug 329300 how to best move forward with that. Mylyn has been restructured, and our issue tracking has moved to GitHub [1]. We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub. [1] https://github.com/orgs/eclipse-mylyn |