Bugzilla – Full Text Bug Listing
| Summary: | [quick assist] Ctrl+1 on missing Javadoc is 'Rename in file' first which wouldn't actually fix the problem | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Remy Suen <remy.suen> | ||||||||
| Component: | Text | Assignee: | Markus Keller <markus.kell.r> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | minor | ||||||||||
| Priority: | P3 | CC: | daniel_megert, markus.kell.r, raksha.vasisht | ||||||||
| Version: | 3.7 | ||||||||||
| Target Milestone: | 3.7 M6 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
The Rename proposals are always on top by design since they are most often used. (In reply to comment #1) > The Rename proposals are always on top by design since they are most often > used. By "always" you mean for Javadoc cases? (In reply to comment #2) > (In reply to comment #1) > > The Rename proposals are always on top by design since they are most often > > used. > > By "always" you mean for Javadoc cases? No, always ;-) Created attachment 185142 [details] Screenshot depicting the behaviour in question. (In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > The Rename proposals are always on top by design since they are most often > > > used. > > > > By "always" you mean for Javadoc cases? > No, always ;-) I must be misinterpreting your statement then because that isn't always at the top for me. Please see attached. (In reply to comment #4) > Created an attachment (id=185142) [details] [diff] > Screenshot depicting the behaviour in question. > > (In reply to comment #3) > > (In reply to comment #2) > > > (In reply to comment #1) > > > > The Rename proposals are always on top by design since they are most often > > > > used. > > > > > > By "always" you mean for Javadoc cases? > > No, always ;-) > > I must be misinterpreting your statement then because that isn't always at the > top for me. Please see attached. Mmh, indeed. Looks like we only do this at some places, e.g. variable declarations. Reopening to either adjust the other cases or fix the Javadoc case. Note that the order has been adjusted before, see bug 283697. Created attachment 189618 [details]
Fix
We have a general problem with the relevance of Quick Assist proposals that also show up when there's a warning or error around the selection.
Quick Fixes are generally more tailored to the actual problem than Quick Assists (Rename, Extract *).
I will lower the relevance of Quick Assists in such cases.
Fixed in HEAD. Verified in I20110301-1537. Works nicely! The fix still shows quick assists ahead of quick fixes sometimes :
public class A {
/**
* blah blah
*
*/
void boo(int ti){
}
}
1. Have your compiler preferences set to warn/error out with missing/malformed
Javadoc.
2. Ctrl +1 shows :
a) Add all missing tags
b) Assign parameter to new field
c) Add '@param' tag
d) Rename ...
e) Rename..
==> Shouldn't (c) come before (b) since it solves the problem and here since I clicked on a param I could also be looking for (c) rather than (a)?
(In reply to comment #10) See bug 339056 |
Created attachment 185130 [details] Screenshot depicting the problem in question. I20101208-1300 (3.7) 1. Have your compiler preferences set to warn/error out with missing/malformed Javadoc. 2. Declare a method that throws an exception. 3. Try to use Ctrl+1 to fix your javadoc, the first proposal is 'Rename in file' which is not really helpful. Please see attached.