Bugzilla – Full Text Bug Listing
| Summary: | [Mac] [cocoa] Toolbar show/hide widget in title trim disappears completely | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Justin Dolezy <justin> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | markus.kell.r, skovatch | ||||
| Version: | 3.6 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | Macintosh | ||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||
| Whiteboard: | stalebug | ||||||
| Attachments: |
|
||||||
|
Description
Justin Dolezy
Created attachment 185129 [details]
Screenshot showing normal state with title trim button, then showing broken state with unrecoverable toolbar
Its seems to be designed that way. The button won't show up unless there is a toolbar to hide. In Eclipse, you can use the Window-Show ToolBar to show the toolbar (and bring back the button) As you said, in RCP apps, you have to use the command to show the button again (or give a menu contribution for that command as the SDK does). I guess the behaviour is correct and hence marking as wont-fix Hi Prakash, I'll have to disagree with you on this! Just because something has been implemented a particular way doesn't necessarily make it right! ;) I imagine it is the way it currently works simply because it's following the visibility behaviour of the IDE show/hide toolbar context & Window menu items? Folks have argued that those are inconsistent anyways, doing effectively the same thing from different places! But anyways... The show/hide toolbar title trim is Mac specific, no? Surely it should then be consistent with other Mac apps? No Mac apps that have the trim visible will ever hide it. If RCP apps behave differently it's going to confuse users on the platform; it's not natural to then later have to find a menu item to undo the change. Actually further to that - by your argument, for full consistency the title trim should actually disappear as soon as you've clicked it to hide the toolbar, no? Having it disappear only after a restart actually makes things worse! The user that actually reported this problem with my app was very "WTF?!" ;) Maybe worth getting Scott Kovatch's opinion, or Silenio, on this?? (In reply to comment #3) > Actually further to that - by your argument, for full consistency the title > trim should actually disappear as soon as you've clicked it to hide the > toolbar, no? Having it disappear only after a restart actually makes things > worse! The user that actually reported this problem with my app was very > "WTF?!" ;) Yes, you are right. Let me look into it > Maybe worth getting Scott Kovatch's opinion, or Silenio, on this?? Sure. Cc-ing Scott. Great! But let's not make it disappear on clicking - that'd definitely be a step backwards; just mentioned that to prove a point! Take a look at CocoaUIEnhancer#modifyWindowShell. If the coolbar or perspective bar is not initially visible we don't call createDummyToolbar. If it's not initially visible, then we create a property change listener that sets it up when the coolbar becomes visible. There's a comment in modifyWindowShell about why this is necessary, but I think the rationale is wrong. You always want to call createDummyToolbar() -- all it does is turn on the native toolbar button and set up the listener for it. It doesn't actually make the coolbar visible. (In reply to comment #0) > On Cocoa (don't recall if the widget appears with carbon, it might..) there is > as a standard Mac button widget in the top right corner which allows users to > show/hide the toolbar/perspective bar in RCP apps - this will probably occur > with the IDE also but I don't want to lose my toolbar :) Actually, it does happen in the IDE, too -- click the button to hide the toolbar, then quit and launch Eclipse again. The button is gone, but you can get the button and the toolbar back with 'Window -> Show Toolbar'. That's also bad UI. The menu item should stay there all the time and change to 'Hide Toolbar' when the toolbar is visible. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the "stalebug" whiteboard tag. |