Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332473

Summary:	excess scroll space in editor sections when content is empty
Product:	z_Archived	Reporter:	Ling Hao <ling.hao>
Component:	Sapphire	Assignee:	Ling Hao <ling.hao>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	konstantin
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:

Description Ling Hao

2010-12-13 16:06:55 EST

Unresolved part from bug 329102 

Problem described in See gallery sample -> Simple Values -> Enums 
isn't quite fixed. The whitespace is smaller,
but is still not the same as beneath other sections on the same page. To fix,
instead of making the parts composite be 0-height, try not to create the
composite in the first place. Even if you make the composite 0-height, you
still have padding between it and the section description. Another way to fix
this might be to use the same composite for description and the section parts
instead of creating a nested composite.

Another option:
what if the section description is rendered the
same way as a label part would be (on the parts composite) instead of the
parent section composite.

Comment 1 Konstantin Komissarchik

2011-03-10 11:56:24 EST

It’s about having more flexibility. Eventually all/most text items in sdef will be functions. For instance, you can embed a property value in the description to make it more specific for the context.

Thinking about this bug some more, I think the approach I’d like to take is to eliminate section descriptions completely. You can always use a label followed by a spacer to achieve the same effect, so there really isn’t a reason for the description to exist as a separate concept.

So…

1. Make the label part use a function instead of static text.
2. Remove section description support.
3. Update the migration document.
4. Update the sample sdefs.
5. Update OEPE sdefs after the merge.

- Konstantin


From: Ling Hao [mailto:ling.hao@oracle.com] 
Sent: Wednesday, March 09, 2011 6:05 PM
To: Konstantin Komissarchik
Subject: Question

Konstantin,
 
I'm trying to fix Bug 332473 - excess scroll space in editor sections when content is empty
 
I'm trying to understand why the description is now a function and why there needs to be a callback, when would the description change? Basically, I'm trying to move this logic in the SapphireLabel.  
 
Thanks,
Ling

Comment 2 Ling Hao

2011-03-14 20:36:51 EDT

checked in.

Comment 3 Konstantin Komissarchik

2011-03-16 00:47:25 EDT

Verified resolution of the excess scroll space issue in Gallery Sample -> Simple Values -> Enums. Verified elimination of section description from the model. Verified migration notes.