Bug 332403

Comment 1 William Seemann 2010-12-12 19:46:53 EST

Created attachment 185036 [details]
Documentation for the refactoring

Comment 2 Jeffrey Overbey 2010-12-13 04:27:47 EST

Hi all,

Thanks a lot for the contribution!  It looks good overall... there are just a
few minor issues I'd like you to fix before we send this on for an IP review. 
Please re-submit the patch with these changes:

1. The copyright header is incorrect for ToggleEndNameTestSuite
-- it assigns copyright to UIUC.  Please also add a brief JavaDoc comment and correct @author tag(s) for that class.

2. Your patch includes files from .svn folders, such as .svn/all-wcprops and .svn/text-base/whereOff.f90.result.svn-base.  I am guessing you accidentally copied over the .svn folders when recreating your changes against CVS HEAD.  Anyway, please exclude all of the .svn entries from the patch (probably, you can just delete the .svn folders altogether).

Thanks a lot!

Jeff

Comment 3 William Seemann 2010-12-13 11:04:08 EST

Created attachment 185073 [details]
Revised patch containing the requested changes

Jeff, here is a patch containing the requested changes.

Comment 4 Jeffrey Overbey 2010-12-13 11:09:15 EST

Looks great; thanks a lot!  Before we send this off for an IP review, could the five of you *each* please confirm that

1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others,

2. you have the right to contribute the code to Eclipse, and

3. you have included the EPL license header in all source files?

Comment 5 William Seemann 2010-12-13 11:14:23 EST

1. you wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,
    I confirm - William Seemann

2. you have the right to contribute the code to Eclipse, and
    I confirm - William Seemann

3. you have included the EPL license header in all source files?
    I confirm - William Seemann

Comment 6 jamesbrooksy 2010-12-13 14:08:07 EST

1. you wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,
    I confirm - Won Jun Jang

2. you have the right to contribute the code to Eclipse, and
    I confirm - Won Jun Jang

3. you have included the EPL license header in all source files?
    I confirm - Won Jun Jang

Comment 7 tchyup 2010-12-13 14:23:10 EST

(In reply to comment #4)
> Looks great; thanks a lot!  Before we send this off for an IP review, could the
> five of you *each* please confirm that
> 
> 1. you wrote 100% of the code without incorporating content from elsewhere or
> relying on the intellectual property of others,
> 
Confirmed.
> 2. you have the right to contribute the code to Eclipse, and
> 
Confirmed.
> 3. you have included the EPL license header in all source files?
Confirmed.

- Jim Tonyan

Comment 8 jsridharma 2010-12-13 18:04:21 EST

1. you wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,
    I confirm - Jegan Sridharma

2. you have the right to contribute the code to Eclipse, and
    I confirm - Jegan Sridharma

3. you have included the EPL license header in all source files?
    I confirm - Jegan Sridharma

Comment 9 Frank 2010-12-13 22:38:02 EST

1. you wrote 100% of the code without incorporating content from elsewhere or
relying on the intellectual property of others,
   I confirm - Francois Toguo

2. you have the right to contribute the code to Eclipse, and
   I confirm - Francois Toguo

3. you have included the EPL license header in all source files?
   I confirm - Francois Toguo

Comment 10 Jeffrey Overbey 2010-12-13 22:48:55 EST

Thanks for the quick replies!

I'll start the IP review process soon.  If the IP team has any questions, I'll post them here.

Comment 11 Jeffrey Overbey 2010-12-13 23:39:06 EST

For the IP review, I will need to describe how much of the work was done by each person involved.  Generally, for CS427 projects, the work was more-or-less evenly distributed, so I will use the following breakdown unless you inform me otherwise:

Won Jun Jang - 20%
William Seemann - 20%
Jegan Sridharma - 20%
Francois Toguo - 20%
Jim Tonyan - 20%

Comment 12 William Seemann 2010-12-14 11:53:09 EST

Jeff, please use the following breakdown:

William 45%
Jang 20%
Jim 15%
Jegan 10%
Francois 10%

Comment 13 Jeffrey Overbey 2010-12-15 11:15:47 EST

CQ 4698 Submitted - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4698

Comment 14 Jeffrey Overbey 2011-01-18 15:10:29 EST

The CQ was approved.  Check in to CVS pending.

Comment 15 Jeffrey Overbey 2014-08-12 11:47:27 EDT

Unfortunately, there is no longer active development on this component.