Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332392

Summary:	NPE in Push dialog
Product:	[Technology] EGit	Reporter:	Gunnar Wagenknecht <gunnar>
Component:	UI	Assignee:	Jens Baumgart <jens.baumgart>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, jens.baumgart
Version:	0.10.0
Target Milestone:	0.10.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Gunnar Wagenknecht

2010-12-12 07:42:20 EST

eclipse.buildId=I20101208-1300
java.version=1.6.0_22
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=de_DE
Command-line arguments:  -os win32 -ws win32 -arch x86


Error
Sun Dec 12 13:39:25 CET 2010
Unhandled event loop exception

java.lang.NullPointerException
at org.eclipse.egit.core.securestorage.EGitSecureStore.calcNodePath(EGitSecureStore.java:83)
at org.eclipse.egit.core.securestorage.EGitSecureStore.putCredentials(EGitSecureStore.java:55)
at org.eclipse.egit.ui.internal.SecureStoreUtils.storeCredentials(SecureStoreUtils.java:36)
at org.eclipse.egit.ui.internal.push.PushWizard.performFinish(PushWizard.java:132)
at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:811)
at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:430)
at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:234)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4084)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3675)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
at org.eclipse.jface.window.Window.open(Window.java:801)
at org.eclipse.egit.ui.internal.repository.tree.command.PushCommand.execute(PushCommand.java:33)
at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
at org.eclipse.ui.menus.CommandContributionItem.handleWidgetSelection(CommandContributionItem.java:824)
at org.eclipse.ui.menus.CommandContributionItem.access$19(CommandContributionItem.java:810)
at org.eclipse.ui.menus.CommandContributionItem$5.handleEvent(CommandContributionItem.java:800)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4084)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3675)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2640)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2604)
at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2438)
at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:671)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:664)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
at org.eclipse.equinox.launcher.Main.run(Main.java:1410)

Comment 1 Gunnar Wagenknecht

2010-12-12 07:47:30 EST

The NPE always happens when clicking on the "Finish" button of the dialog. The remote repo is a GitHub repo configured via SSH (username "git", no password, SSH key auth).

Comment 2 Gunnar Wagenknecht

2010-12-12 07:48:44 EST

BTW, I tried different remote push configurations - one with "Store in secure store" checked and the other one with unchecked. Still the same error.

Comment 3 Gunnar Wagenknecht

2010-12-12 07:51:45 EST

Eclipse 3.7M4
EGit 0.10.0.201012101928

Comment 4 Jens Baumgart

2010-12-13 05:26:06 EST

Fix proposed: http://egit.eclipse.org/r/2108

Comment 5 Chris Aniszczyk

2010-12-13 09:44:45 EST

Fixed, thanks for reporting the issue.