Bugzilla – Full Text Bug Listing
| Summary: | aggregator doesn't report low level parsing errors in email | ||
|---|---|---|---|
| Product: | [Technology] CBI | Reporter: | David Williams <david_williams> |
| Component: | CBI p2 Repository Aggregator | Assignee: | CBI Inbox <cbi-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | David Williams <david_williams> |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | filip.hrbek, frederic.gurr, thomas |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
I see now I was incorrect in saying the error message was not logged.
Looking back today, I do see it in log:
[exec]
[exec] file:/shared/indigo/org.eclipse.indigo.build/ep.b3aggrcon: org.eclipse.emf.ecore.xmi.IllegalValueException: Value 'v20101118-7Q7xA7DPa2xdN86nbxlooGNr6aWgeOpuz-xq-WrZxV_3Q' is not legal. (file:/shared/indigo/org.eclipse.indigo.build/ep.b3aggrcon, 7, 124)
[exec] Build failed! Exception was org.eclipse.core.runtime.CoreException: Not all contributions could be parsed
[exec] Not all contributions could be parsed
[exec] Eclipse:
[exec] No exit data available.
[exec] Eclipse:
[exec] Java was started but returned exit code=13
I think I missed it because normally I look for error messages by searching for an messages wrapped in something like "email to: "
So, I remember to also look right before "exit" statement ... but, will leave this open, as I think an email should be sent to contacts in offending team.
Changing to enhancement request. I suspect this is a whole different area of code than the normal email error reporting, and is not a true "bug in code", but a limitation with design. Or something.
I think one of the reasons why no email is sent is that this happens very early when the model is parsed. Since the parsing fails, the email address is not yet known. I guess one way to rectify that would be to add a command line option for the top-level email. (In reply to comment #2) > I think one of the reasons why no email is sent is that this happens very early > when the model is parsed. Since the parsing fails, the email address is not yet > known. I guess one way to rectify that would be to add a command line option > for the top-level email. True, but perhaps we do have a chance to get the buildmaster's email if it's only a contribution (or contributions) what is invalid, in case it is a detached file. It means that the main build file is parseable and becomes invalid only when an attempt to resolve the proxy URI to the contribution is made. Of course, if the contribution itself if invalid, we can't discover an email belonging to the contribution, but we can send an email to the buildmaster, telling him which contribution URI could not be resolved. *** Bug 329651 has been marked as a duplicate of this bug. *** [Bookkeeping change only. Moving bugs to the new "home" of aggregator, CBI.] If this issue is still relevant, please move it to https://github.com/eclipse-cbi/p2repo-aggregator/issues. |
The aggregator reports most errors very well, either in buildlog and usually send eamil on the problem. There is a type of parse error though that does not get reported, the build ends with a "java -13 errror" but the root error can be found in the .log file in the workspace created during the build. The root error was the ep.b3aggcontr file had <features name="org.eclipse.sdk.feature.group" versionRange="v20101118-7Q7xA7DPa2xdN86nbxlooGNr6aWgeOpuz-xq-WrZxV_3Q"/> instead of <features name="org.eclipse.sdk.feature.group" versionRange="3.7.0.v20101118-7Q7xA7DPa2xdN86nbxlooGNr6aWgeOpuz-xq-WrZxV_3Q"/> The .log file ends with this error message: !ENTRY org.eclipse.b3.util 4 -364274674 2010-12-10 17:31:52.341 !MESSAGE file:/shared/indigo/org.eclipse.indigo.build/ep.b3aggrcon: org.eclipse.emf.ecore.xmi.IllegalValueException: Value 'v20101118-7Q7xA7DPa2xdN86nbxlooGNr6aWgeOpuz-xq-WrZxV_3Q' is not legal. (file:/shared/indigo/org.eclipse.indigo.build/ep.b3aggrcon, 7, 124) !ENTRY org.eclipse.b3.util 4 -364274674 2010-12-10 17:31:52.632 !MESSAGE Build failed! Exception was org.eclipse.core.runtime.CoreException: Not all contributions could be parsed !STACK 1 org.eclipse.core.runtime.CoreException: Not all contributions could be parsed at org.eclipse.b3.util.ExceptionUtils.fromMessage(ExceptionUtils.java:53) at org.eclipse.b3.util.ExceptionUtils.fromMessage(ExceptionUtils.java:49) at org.eclipse.b3.aggregator.engine.Builder.verifyContributions(Builder.java:1112) at org.eclipse.b3.aggregator.engine.Builder.loadModel(Builder.java:940) at org.eclipse.b3.aggregator.engine.Builder.run(Builder.java:552) at org.eclipse.b3.aggregator.engine.Builder.run(Builder.java:822) at org.eclipse.b3.cli.AbstractCommand.run(AbstractCommand.java:119) at org.eclipse.b3.cli.Headless.run(Headless.java:130) at org.eclipse.b3.cli.Headless.start(Headless.java:197) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:79) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:618) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574) at org.eclipse.equinox.launcher.Main.run(Main.java:1407) !SUBENTRY 1 org.eclipse.b3.util 4 0 2010-12-10 17:31:52.633 !MESSAGE Not all contributions could be parsed One build log that shows this case is (currently) at https://hudson.eclipse.org/hudson/view/Repository%20Aggregation/job/indigo.runAggregator/157/console and is fairly normal, except is just ends with BUILD FAILED /opt/public/indigo/org.eclipse.indigo.tools/build.xml:197: exec returned: 13 It would be nice if these parse errors were at least logged in the usual buildlog, and ideally email sent to the contacts in the b3aggrcon file that could not be parsed.