Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332327

Summary: [Compatibility] <dynamic> org.eclipse.ui.menus contributions to text editors appears to be ignored
Product: [Eclipse Project] e4 Reporter: Remy Suen <remy.suen>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: major    
Priority: P3 CC: pwebster
Version: 1.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Remy Suen CLA 2010-12-10 13:10:32 EST
The snippet below does not work on 4.1.

<extension point="org.eclipse.ui.menus">
  <menuContribution locationURI="popup:#TextEditorContext?after=additions">
    <dynamic
        class="b.items.CCIImpl"
        id="b.items.cci">
    </dynamic>
  </menuContribution>
</extension>
Comment 1 Remy Suen CLA 2010-12-10 13:21:16 EST
Looks like it may be because MenuAdditionCacheEntry's addMenuChildren(*) method doesn't consider <dynamic> elements.
Comment 2 Remy Suen CLA 2010-12-10 13:48:41 EST
Actually, based on bug 332240, it feels like you'll appear if you're nested within a <menu> but won't if you're not?
Comment 3 Remy Suen CLA 2010-12-10 14:52:57 EST
See also bug 329439 for the targeted view case.
Comment 4 Remy Suen CLA 2011-05-16 14:51:33 EDT
The snippet seems to be working now.