Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332240

Summary:

[Compatibility] Invalid CompoundContributionItem contributions are showing up

Product:

[Eclipse Project] e4

Reporter:

Remy Suen <remy.suen>

Component:

Assignee:

Project Inbox <e4.ui-inbox>

Status:

RESOLVED WORKSFORME

QA Contact:

Severity:

normal

Priority:

CC:

kjdoyle, mober.at+eclipse, pwebster, xuanchen

Version:

1.0

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

331440

Attachments:

Description	Flags
Screenshot depicting the problem in question.	none

Description Remy Suen

2010-12-09 14:32:19 EST

Created attachment 184889 [details]
Screenshot depicting the problem in question.

The XML definition appears to use a compound visibleWhen clause with an activeMenuSelection query, property testers, and adaptation checks.

http://dev.eclipse.org/viewcvs/viewvc.cgi/org.eclipse.tm.rse/plugins/org.eclipse.rse.useractions/plugin.xml?view=markup&revision=1.13&root=DSDP_Project

Comment 1 Martin Oberhuber

2010-12-10 10:05:45 EST

Xuan, can you comment on what the compile commands _should_ look like ?

Comment 2 Remy Suen

2010-12-10 10:10:08 EST

I should've been more specific. The left-hand side of the screenshot is 4.1 and the right-hand side is 3.7. So it seems like they're just not supposed to show up at all.

However, Xuan's confirmation of this would of course be helpful. :)

Comment 3 Paul Webster

2010-12-13 10:15:03 EST

We might not be applying the visibleWhen expression to our MMenus at all.

PW

Comment 4 Xuan Chen

2010-12-14 12:12:09 EST

The one on the right (3.7) is the right now.  Compile Command User Action menu should not appear for local shell.

Comment 5 Remy Suen

2011-05-16 14:22:02 EDT

No longer appears to be a problem with I20110515-0800. This may have been fixed by Paul's activeMenuSelection changes from bug 325390 comment 11.