Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332198

Summary:

Deep deletion feature in refining mode.

Product:

[Modeling] MMT.ATL

Reporter:

Salvador Martínez <salva.martinez.perez>

Component:

Contribution

Assignee:

mmt-atl.web-inbox <mmt-atl.web-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

dwagelaar, william.piers

Version:

unspecified

Flags:

william.piers: iplog+

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

343066

Bug Blocks:

Attachments:

Description	Flags
Deep deletion implementation and tests.	none
Zip adressing revision comments	none

Description Salvador Martínez

2010-12-09 04:31:34 EST

Created attachment 184843 [details]
Deep deletion implementation and tests.

Here is the code that adds deep deletion feature in ATL refining Mode.

This implementation allows explicitly deleting elements while working in refining mode through a new keyword, "drop", that has been introduced in the ATL language. This deletion feature will delete the matched element of the rule along with all its contained elements.

A Patch is provided for the definition of the language (ATL+ACG Metamodel, parser and compiler). After the compilation/generation over the patched definition several elements must be copied into ATL plugins (A patch performing this copy can be provided if needed):

For ATL related elements:

ATL.asm, ATL.ecore and RefiningTrace.ecore Has to be copied to org.eclipse.m2m.atl.common and org.eclipse.m2m.atl.dsls.resources.ATL
ATL-TCS.xmi has to be copied to org.eclipse.m2m.atl.dsls.resources.ATL

ATL_ANTLR3Lexer, ATL_ANTLR3Parser, ATL_ANTLR3__.g and ATL_ANTLR3.tokens has to be copied to org.eclipse.m2m.atl.dsls.tcs.injector

For ACG related elements: 

ACG.asm, ACG.ecore and ACG-TCS.xmi has to be copied to org.eclipse.m2m.atl.dsls.resources.ACG

The implementation relies for the deletion in the EMF virtual machine so it is affected for the bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=332194.

This implementation also fixes the bug: https://bugs.eclipse.org/bugs/show_bug.cgi?id=332196



Please, find a zip attachment containing:

ATLRefiningDefinitions.txt: Patch for ATL definition (Metamodel, parser and compiler)

org.eclipse.m2m.atl.compilers.Atl2010InPlace.zip: New plug-in to register the new compiler.

patchLexems.txt: Patch for the IAtlLexems.java to allow the new keyword to be highlighted in the ATL editor.

Tests.zip: A test suite containing Mematodel, Model and transformation to test the new functionality.

Comment 1 William Piers

2010-12-16 05:10:42 EST

Hi,

First, thanks for this contribution !
Before I can submit the CQ you will have to make some fixes to the attached zip:
- remove the .svn files and repositories
- fix copyrights: Activator.java doesn't have one and the one in the compiler class seems to be out of date ("2004")
Here is a page about copyrights http://www.eclipse.org/legal/copyrightandlicensenotice.php 

For the CQ submission I need also the following informations about you:
- name
- organization
- email address and/or phone number

Finally, please confirm that you:

1.  Developed 100% of the content from scratch without incorporating content
from elsewhere or relying on the intellectual property of others.

2.  Have the rights to contribute the content to Eclipse

3.  Provide the content under the terms of the EPL to be included in
future releases of Eclipse. 

Thanks in advance !

Comment 2 Salvador Martínez

2010-12-16 08:50:52 EST

Created attachment 185313 [details]
Zip adressing revision comments

Comment 3 Salvador Martínez

2010-12-16 08:54:16 EST

Information for the CQ submission:

- Salvador Martínez Pérez
- AtlanMod Team, INRIA/EMN
- Salvador.Martinez_Perez@inria.fr

Comment 4 Salvador Martínez

2010-12-16 08:54:44 EST

I author 100% of the content
I have the rights to donate the content to Eclipse
I contribute the contend under the EPL

Comment 5 Salvador Martínez

2011-04-17 10:36:14 EDT

Two bugs has been discovered and patches proposed to fix them. This affects mainly the execution of transformations through the launcher wizard:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=343065
https://bugs.eclipse.org/bugs/show_bug.cgi?id=343066

Comment 6 William Piers

2011-05-05 05:32:29 EDT

The contribution has been integrated into ATL CVS HEAD.

Comment 7 Dennis Wagelaar

2017-06-05 09:09:25 EDT

This was released for ATL 3.2 - closing.