Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332191

Summary: Expression text hover should use fallback if no parsing information is available
Product: [Tools] CDT Reporter: Anton Leherbauer <aleherb+eclipse>
Component: cdt-debugAssignee: Anton Leherbauer <aleherb+eclipse>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: normal    
Priority: P3 CC: cdtdoug, pawel.1.piech
Version: 7.0   
Target Milestone: 7.0.2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Fix
aleherb+eclipse: iplog-
Committed fix aleherb+eclipse: iplog-

Description Anton Leherbauer CLA 2010-12-09 02:18:04 EST
The default implementation of AbstractDebugTextHover.getExpressionText() return null if no parsing information is available.  In this case it should fall back to the text marked by the hoverRegion.
Comment 1 Anton Leherbauer CLA 2010-12-13 05:00:49 EST
Created attachment 185045 [details]
Fix

This addresses also a few other issues:
- selected expression were not handled properly
- simple assignments were not filtered out
Comment 2 Anton Leherbauer CLA 2010-12-13 09:25:12 EST
Created attachment 185060 [details]
Committed fix

This also takes into account an expression in code which is (incorrectly) marked as inactive.
Comment 3 Anton Leherbauer CLA 2010-12-13 09:27:15 EST
Fixed in 7.0.2 and HEAD.