Bug 332189

Comment 1 Christ van Willegen 2010-12-09 02:05:08 EST

Created attachment 184840 [details]
Test case showing incorrect syntax coloring

Comment 2 xu jiaxi 2010-12-13 21:42:50 EST

Created attachment 185104 [details]
patch

Comment 3 Zhongwei Zhao 2011-01-10 02:50:01 EST

committed to head,thanks Xu!

Comment 4 Roy Ganor 2011-01-10 02:57:37 EST

(In reply to comment #3)
> committed to head,thanks Xu!

Just to be sure, is this a valid PHP code? can you run it with the php binary and get no errors when executing it?
 
Thanks!

Comment 5 Zhongwei Zhao 2011-01-10 04:08:46 EST

hi,Roy

I use this php file to test:

<?php

function echoHereDoc($hereDoc)
{
	echo $hereDoc;
}
/**
 * TODO abscsfdds
 * Enter description here ...
 */
function test()
{
	echoHereDoc(<<<EOF
set term png size 1300, 600
set xdata time
set xlabel "$test"
set ylabel "Aantal per minuut"
set timefmt "%Y-%m-%d_%H:%M"
set format x "%H:%M:%S"
set key outside bottom
set output "/var/www/html/arponline/arponline.data/plot.png"
plot
EOF
	);
}
test();

and it print:

set term png size 1300, 600
set xdata time
set xlabel "Test"
set ylabel "Aantal per minuut"
set timefmt "%Y-%m-%d_%H:%M"
set format x "%H:%M:%S"
set key outside bottom
set output "/var/www/html/arponline/arponline.data/plot.png"
plot


so I think it is a valid php code,and I will write test for it and fix the unit test failure:)

Comment 6 Roy Ganor 2011-01-10 09:18:35 EST

Great, so it sounds like an important issue that we need to apply to the branch as well.

Do we have unit tests for this issue?

Comment 7 Zhongwei Zhao 2011-01-10 09:30:24 EST

(In reply to comment #6)
> Great, so it sounds like an important issue that we need to apply to the branch
> as well.
> 
> Do we have unit tests for this issue?

not yet,I will add it tomorrow

Comment 8 Zhongwei Zhao 2011-01-11 05:26:11 EST

there is problem with Xu's patch.for example:
<?
<<<MY_MARKER
Hello world
Bye Bye world
Bla Bla Bla
MY_MARKER;
b<<<MY_MARKER_2
Hello world
Bye Bye world
Bla Bla Bla
MY_MARKER_2;
<<<"MY_MARKER_3"
Hello world
Bye Bye world
Bla Bla Bla
MY_MARKER_3;

Comment 9 Zhongwei Zhao 2011-01-11 05:27:17 EST

Created attachment 186472 [details]
patch

patch and unit test

Comment 10 Kalin 2011-07-29 08:42:55 EDT

Still reproducible using the code in Comment 8
See the attachment.

Comment 11 Kalin 2011-07-29 08:44:53 EDT

Created attachment 200589 [details]
screenshot1

Comment 12 Zhongwei Zhao 2011-08-02 02:52:44 EDT

fixed

Comment 13 Toshihiro Izumi 2011-08-03 05:05:03 EDT

(In reply to comment #11)
> Created attachment 200589 [details]
> screenshot1

Because the last "MY_MARKER_3;" is *not* the end of heredoc(T_END_HEREDOC).
Run the script. You get
Parsing Error: /php/errfile.php line 16 - syntax error, unexpected $end, expecting T_VARIABLE or T_END_HEREDOC or T_DOLLAR_OPEN_CURLY_BRACES or T_CURLY_OPEN

Comment 14 Kalin 2011-08-05 09:07:07 EDT

Ok,thanks Toshihiro!
I'm closing it, since the given example in Comment 8 is not good.