Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332174

Summary:

RemoveComponentFromEnterpriseApplicationOperation should first try to remove based on the dependent object

Product:

[WebTools] WTP Java EE Tools

Reporter:

Aidyl Kareh <amkareh>

Component:

jst.j2ee

Assignee:

Aidyl Kareh <amkareh>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

amkareh, ccc, jsholl

Version:

unspecified

Flags:

cbridgha: review+

Target Milestone:

3.2.3

Hardware:

OS:

Windows Vista

Whiteboard:

Attachments:

Description	Flags
Proposed Patch	none
Proposed Patch - Updated	none

Description Aidyl Kareh

2010-12-08 17:18:50 EST

Build Identifier: WTP 3.2.3

The RemoveComponentFromEnterpriseApplicationOperation class currently first tries to remove the module based on the dependent object. However, this is not done if the module is a binary file.

Reproducible: Always

Comment 1 Aidyl Kareh

2010-12-08 17:23:19 EST

Created attachment 184821 [details]
Proposed Patch

This patch updates the AddComponentToEnterpriseApplicationOp so that it sets the dependent object when the binary module is added and the RemoveComponentFromEnterpriseApplicationOperation so that it uses the dependent object when removing the binary module.

Comment 2 Aidyl Kareh

2010-12-09 13:17:36 EST

Created attachment 184879 [details]
Proposed Patch - Updated

Updated patch to reuse the same findReferencedComponent method in both classes.

Comment 3 Chuck Bridgham

2010-12-09 13:45:55 EST

approve

Comment 4 Jason Sholl

2010-12-10 10:27:52 EST

Code checked into 32M and HEAD for WTP 3.2.3 and 3.3