Bugzilla – Full Text Bug Listing
| Summary: | Conflicting keyboard shortcut: CTRL+ALT+P (Prepare Changelog vs. Prepare Changelog in an editor)? | ||
|---|---|---|---|
| Product: | [Tools] Linux Tools | Reporter: | Severin Gehwolf <sgehwolf> |
| Component: | ChangeLog | Assignee: | Andrew Ferrazzutti <af_0_af> |
| Status: | RESOLVED INVALID | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | akurtakov, jjohnstn, linux.changelog-inbox, overholt |
| Version: | 0.7.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
|
Description
Severin Gehwolf
It seems like a bug to me :) When was this fixed, Jeff? 0.8? Is this bug really fixed ? Should we close it? This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. Andrew, would you please look into this one. I can confirm that this error still happens, and that there's also apparently a conflict with the ALT+CTRL+C binding as well. I'll look into it. (In reply to Andrew Ferrazzutti from comment #6) > I can confirm that this error still happens, and that there's also > apparently a conflict with the ALT+CTRL+C binding as well. I'll look into it. There was another bug for this issue which I proposed a solution and didn't receive any comments: https://bugs.eclipse.org/bugs/show_bug.cgi?id=296587 At the time of this writing, the keybinding conflicts still exist, but they don't cause any problems at user-level. Since each of the "conflicting" keybindings are each active in a different, non-conflicting context, there is no real conflict to speak of. For instance, the ALT+CTRL+P keybindings that trigger the "Prepare Changelog" command are each active in three non-conflicting contexts: Window, Text Editor, and Compare Editor. I tested using that keybinding in those contexts, and as far as I could tell, they never conflict with each other. The ALT+CTRL+C keybinding has a similar situation: the same keybinding is used for Subversive SVN's "Prepare Commit" command, but it's only active in Windows whereas Changelog's keybinding is active in Text/Compare Editors. Due to this, they don't conflict with each other in practice. Finally, when looking through my Eclipse's Error Log, I found some other keybinding conflicts from other plugins. Trying to use any one of them causes the Key Assist popup to appear, which lists all of the commands provided by that keybinding and lets you choose the one you want to execute. It's the same popup that appears when you input an incomplete two-phase key shortcut, like Shift+Alt+X or Shift+Alt+Q. This also means that we don't need to worry about future plugins that will potentially use the same keybindings as Changelog (a point that was made in #296587). I wonder if Eclipse had this feature when this bug was first reported, since it's a good solution to the general issue of key conflicts. Considering all this, I'm marking this as resolved. If anyone still has concerns about it, we can discuss it in the comments, but I don't see much of a reason to leave this as an open bug. |