Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 332136

Summary:

[ds] Update package org.apache.felix.scr with the latest available one

Product:

[Eclipse Project] Equinox

Reporter:

Stoyan Boshev <s.boshev>

Component:

Compendium

Assignee:

Stoyan Boshev <s.boshev>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

tjwatson

Version:

3.7

Target Milestone:

3.7 M5

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch with the necessary changes	none
patch update	none

Description Stoyan Boshev

2010-12-08 10:13:08 EST

The ds bundle exports the org.apache.felix.scr package version 1.2. We need to update it to the latest one - verison 1.6. Accordingly, the DS implementation must be adopted to implement the changes.

Comment 1 Stoyan Boshev

2010-12-08 10:19:34 EST

Created attachment 184793 [details]
patch with the necessary changes

Comment 2 Thomas Watson

2010-12-08 10:32:22 EST

I think the ds bundle should make the scr package substitutable by also improting:

Import-Package: org.apache.felix.scr; version="[1.6,1.7)"

I recommend a tight range so that ds is not wired to a version >= 1.7 since DS implements the package.

Comment 3 Stoyan Boshev

2010-12-08 10:42:33 EST

(In reply to comment #2)
> I think the ds bundle should make the scr package substitutable by also
> improting:
> 
> Import-Package: org.apache.felix.scr; version="[1.6,1.7)"
> 
> I recommend a tight range so that ds is not wired to a version >= 1.7 since DS
> implements the package.

I agree. 
I think the bundle version should also be changed. Shall I change it from 1.2.100 to 1.3?

Comment 4 Thomas Watson

2010-12-08 13:49:50 EST

(In reply to comment #3)
> I agree. 
> I think the bundle version should also be changed. Shall I change it from
> 1.2.100 to 1.3?

Yes, bundle version should be changed to 1.3.  Thanks.

Comment 5 Stoyan Boshev

2010-12-09 08:33:49 EST

Created attachment 184847 [details]
patch update

Comment 6 Thomas Watson

2010-12-13 10:26:57 EST

Thanks Stoyan, please release this today if possible.  Would like to tag it for the first M5 build.

Comment 7 Thomas Watson

2010-12-13 15:32:53 EST

I released the patch.  I also added the necessary .api_filters to ignore apache APIs for the api tooling errors for adding methods to interfaces implemented by clients.  The apache API does not use the @noimplement tags so we must filter these errors.